CFNv2: Support stack sets #12909
Merged
CFNv2: Support stack sets #12909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: patch
simonrw
force-pushed
the
cfn/v2/stack-sets
branch
from
ec4b9b9 to
2f3aa84
Compare
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 23m 23s ⏱️ - 1h 21m 38s Results for commit 2f3aa84. ± Comparison against base commit 34049aa. This pull request removes 4040 and adds 2 tests. Note that renamed tests count towards both.This pull request removes 213 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 32m 47s ⏱️ Results for commit 2f3aa84. |
pinzon
approved these changes
Jul 28, 2025
Comment on lines
+782
to
+787
| # wait for completion of stack | ||
| for stack_name, account_id, region_name in stacks_to_await: | ||
| client = connect_to( | ||
| aws_access_key_id=account_id, region_name=region_name | ||
| ).cloudformation | ||
| client.get_waiter("stack_create_complete").wait(StackName=stack_name) |
Member
There was a problem hiding this comment.
comment: is this correct? Maybe a better approach would be to put this code in a separate thread and update the stack set operation status depending on the result of the waits.
Contributor
Author
There was a problem hiding this comment.
I think you are right but I think you have two suggestions here:
- run each stack instance concurrently in a background thread
- don't assume success and handle the error
I don't think point 1. is worth tackling at this stage, however point 2 is very relevant. I would like to tackle this in a follow up since this PR does not support successfully deploying stack instances. See the note here.
I have started a PR to create a validated stack sets test. I think the step after that is to handle error cases. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The CloudFormation V1 provider had basic support for stack sets, with a single test covering the functionality. This functionality should be ported over to the new provider.
Changes
Testing
Unfortunately there is manual set up required for testing stack sets. See the docs here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/stacksets-prereqs-self-managed.html so this change does not test/assert the behaviour of deployed resources though they were manually verified.