Skip to content

CFNv2: Support the list parameter type #12904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonrw merged 1 commit into from
Jul 24, 2025
Merged

CFNv2: Support the list parameter type #12904

simonrw merged 1 commit into from
Jul 24, 2025

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Jul 24, 2025

Motivation

We don't currently support the list parameter type

Changes

Now we do!

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Jul 24, 2025
@github-actions
Copy link

github-actions bot commented Jul 24, 2025

Test Results - Preflight, Unit

21 983 tests  ±0   20 249 ✅ ±0   6m 29s ⏱️ -8s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit cef43b0. ± Comparison against base commit 7f1ce47.

@github-actions
Copy link

github-actions bot commented Jul 24, 2025

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   23m 24s ⏱️ - 1h 22m 41s
898 tests  - 4 040  334 ✅  - 3 827  564 💤  - 213  0 ❌ ±0 
900 runs   - 4 040  334 ✅  - 3 827  566 💤  - 213  0 ❌ ±0 

Results for commit cef43b0. ± Comparison against base commit 7f1ce47.

This pull request removes 4040 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions
Copy link

github-actions bot commented Jul 24, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 8s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit cef43b0. ± Comparison against base commit 7f1ce47.

@github-actions
Copy link

github-actions bot commented Jul 24, 2025

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   35m 9s ⏱️
922 tests 359 ✅ 563 💤 0 ❌
928 runs  359 ✅ 569 💤 0 ❌

Results for commit cef43b0.

@simonrw simonrw marked this pull request as ready for review July 24, 2025 17:42
pinzon
pinzon approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simonrw simonrw merged commit c917f50 into main Jul 24, 2025
42 checks passed
@simonrw simonrw deleted the cfn/v2/list-parameter-type branch July 24, 2025 20:11
@simonrw simonrw mentioned this pull request Sep 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simonrw @pinzon