Skip to content

Ignore all type errors from mypy when debugpy is installed #12893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonrw merged 1 commit into from
Jul 24, 2025
Merged

Ignore all type errors from mypy when debugpy is installed #12893

simonrw merged 1 commit into from
Jul 24, 2025

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Jul 22, 2025

Motivation

Our pre-push hook runs mypy, but if debugpy is installed, I get the following error:

localstack/packages/debugpy.py:23: error: Unused "type: ignore" comment  [unused-ignore]
localstack/packages/debugpy.py:23: error: Skipping analyzing "debugpy": module is installed, but missing library stubs or py.typed marker  [import-untyped]
localstack/packages/debugpy.py:23: note: Error code "import-untyped" not covered by "type: ignore" comment
localstack/packages/debugpy.py:23: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 2 errors in 1 file (checked 15 source files)
make: *** [Makefile:124: lint] Error 1
error: failed to push some refs to 'github.com:localstack/localstack.git'

This prevents the push for a reason that is not important.

Changes

Ignore all type errors with debugpy as it's not a crucial part of our typing setup

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Jul 22, 2025
@github-actions
Copy link

github-actions bot commented Jul 22, 2025

Test Results - Preflight, Unit

21 983 tests  ±0   20 249 ✅ ±0   6m 47s ⏱️ +27s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit cb2d448. ± Comparison against base commit 75858d8.

@github-actions
Copy link

github-actions bot commented Jul 22, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit cb2d448. ± Comparison against base commit 75858d8.

@github-actions
Copy link

github-actions bot commented Jul 22, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 36s ⏱️
5 289 tests 4 359 ✅ 930 💤 0 ❌
5 295 runs  4 359 ✅ 936 💤 0 ❌

Results for commit cb2d448.

@github-actions
Copy link

github-actions bot commented Jul 22, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 44m 49s ⏱️ +30s
4 930 tests ±0  4 153 ✅ ±0  777 💤 ±0  0 ❌ ±0 
4 932 runs  ±0  4 153 ✅ ±0  779 💤 ±0  0 ❌ ±0 

Results for commit cb2d448. ± Comparison against base commit 75858d8.

@simonrw simonrw marked this pull request as ready for review July 23, 2025 22:28
@simonrw simonrw requested a review from alexrashed as a code owner July 23, 2025 22:28
@simonrw simonrw requested a review from dfangl July 23, 2025 22:28
@simonrw simonrw added this to the Playground milestone Jul 24, 2025
@simonrw simonrw merged commit 7f1ce47 into main Jul 24, 2025
42 checks passed
@simonrw simonrw deleted the debugpy/ignore-type-errors branch July 24, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfangl dfangl dfangl approved these changes

@alexrashed alexrashed Awaiting requested review from alexrashed alexrashed is a code owner

Assignees

No one assigned

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

Playground

Development

Successfully merging this pull request may close these issues.

2 participants

@simonrw @dfangl