Skip to content

CFnV2: add stack events when there are errors during preprocessing #12892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonrw merged 2 commits into from
Jul 24, 2025
Merged

CFnV2: add stack events when there are errors during preprocessing #12892

simonrw merged 2 commits into from
Jul 24, 2025

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Jul 22, 2025

Motivation

While the provider is still new with edge cases, it's frustrating to find out the cause of the error if it occurs during preprocessing.

With this change, a stack event is captured during resource deployment time so at least the error message is shown in the stack events.

Changes

  • Add stack event on resource preprocessing failure

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Jul 22, 2025
@github-actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 983 tests  ±0   20 249 ✅ ±0   6m 26s ⏱️ +4s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 07f06d0. ± Comparison against base commit 75858d8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   23m 27s ⏱️ - 1h 21m 48s
898 tests  - 4 032  334 ✅  - 3 819  564 💤  - 213  0 ❌ ±0 
900 runs   - 4 032  334 ✅  - 3 819  566 💤  - 213  0 ❌ ±0 

Results for commit 07f06d0. ± Comparison against base commit 75858d8.

This pull request removes 4035 and adds 3 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.cloudformation.api.test_stacks ‑ test_non_existing_stack_message
tests.aws.services.cloudformation.resources.test_apigateway ‑ test_apigateway_deployment_canary_settings
tests.aws.services.cloudformation.resources.test_ec2 ‑ test_vpc_gateway_attachment

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 9s ⏱️ -7s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 07f06d0. ± Comparison against base commit 75858d8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files  ±    0    5 suites  ±0   34m 43s ⏱️ - 1h 46m 53s
922 tests  - 4 367  359 ✅  - 4 000  563 💤  - 367  0 ❌ ±0 
928 runs   - 4 367  359 ✅  - 4 000  569 💤  - 367  0 ❌ ±0 

Results for commit 07f06d0. ± Comparison against base commit 75858d8.

This pull request removes 4370 and adds 3 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.cloudformation.api.test_stacks ‑ test_non_existing_stack_message
tests.aws.services.cloudformation.resources.test_apigateway ‑ test_apigateway_deployment_canary_settings
tests.aws.services.cloudformation.resources.test_ec2 ‑ test_vpc_gateway_attachment

♻️ This comment has been updated with latest results.

@simonrw simonrw modified the milestones: Playground, 4.8 Jul 24, 2025
@simonrw simonrw marked this pull request as ready for review July 24, 2025 14:22
pinzon
pinzon approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

localstack-core/localstack/services/cloudformation/engine/v2/change_set_model.py
Comment on lines +113 to +120
def to_change_action(self) -> ChangeAction:
# Convert this change type into the change action used throughout the CFn API
return {
ChangeType.CREATED: ChangeAction.Add,
ChangeType.MODIFIED: ChangeAction.Modify,
ChangeType.REMOVED: ChangeAction.Remove,
}.get(self, ChangeAction.Add)

Copy link
Member

@pinzon pinzon Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: Nice! 👍

@simonrw simonrw merged commit ba66ba1 into main Jul 24, 2025
39 checks passed
@simonrw simonrw deleted the cfn/v2/events-on-preproc-errors branch July 24, 2025 16:36
@simonrw simonrw mentioned this pull request Sep 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.8

Development

Successfully merging this pull request may close these issues.

3 participants

@simonrw @pinzon