Skip to content

Lambda: Proper error handling for code in S3 #12883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dfangl merged 1 commit into from
Jul 22, 2025
Merged

Lambda: Proper error handling for code in S3 #12883

dfangl merged 1 commit into from
Jul 22, 2025

Conversation

@dfangl
Copy link
Member

@dfangl dfangl commented Jul 21, 2025

Motivation

Currently, we do not properly catch the case of users specifiying invalid S3 code locations.

This leads to 500 errors with long stacktraces thrown, we should properly handle those cases instead.

Changes

  • Add test for S3 code with invalid locations
  • Properly catch the s3 error and return the correct one to the sender

@dfangl dfangl requested a review from joe4dev as a code owner July 21, 2025 17:58
@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Jul 21, 2025
@dfangl dfangl self-assigned this Jul 21, 2025
@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Jul 21, 2025
@github-actions
Copy link

github-actions bot commented Jul 21, 2025

Test Results - Preflight, Unit

21 983 tests  ±0   20 249 ✅ ±0   6m 32s ⏱️ +14s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 3f770cb. ± Comparison against base commit 36014d4.

@github-actions
Copy link

github-actions bot commented Jul 21, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ +15s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 3f770cb. ± Comparison against base commit 36014d4.

@github-actions
Copy link

github-actions bot commented Jul 21, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 50m 54s ⏱️
3 738 tests 3 066 ✅ 672 💤 0 ❌
3 744 runs  3 066 ✅ 678 💤 0 ❌

Results for commit 3f770cb.

@github-actions
Copy link

github-actions bot commented Jul 21, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 22m 38s ⏱️ - 23m 7s
3 714 tests  - 1 215  3 039 ✅  - 1 112  675 💤  - 103  0 ❌ ±0 
3 716 runs   - 1 215  3 039 ✅  - 1 112  677 💤  - 103  0 ❌ ±0 

Results for commit 3f770cb. ± Comparison against base commit 36014d4.

This pull request removes 1216 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.lambda_.test_lambda_api.TestLambdaFunction ‑ test_lambda_code_location_s3_errors

joe4dev
joe4dev approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for covering both create and update cases ✨ 💯

@dfangl dfangl merged commit 75858d8 into main Jul 22, 2025
44 checks passed
@dfangl dfangl deleted the lambda/s3-error-handling branch July 22, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joe4dev joe4dev joe4dev approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

Assignees

@dfangl dfangl

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dfangl @joe4dev