CFNv2: support validation of CAPABILITY_AUTO_EXPAND #12864
Conversation
simonrw
added
the
semver: patch
LocalStack Community integration with Pro 2 files 2 suites 22m 21s ⏱️ Results for commit 542955c. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 34m 41s ⏱️ Results for commit 542955c. ♻️ This comment has been updated with latest results. |
pinzon
left a comment
pinzon
left a comment
There was a problem hiding this comment.
LGTM in general but we need to make sure CAPABILITY_AUTO_EXPAND are only necessary for global transforms.
|
|
||
| if ( | ||
| "CAPABILITY_AUTO_EXPAND" not in request.get("Capabilities", []) | ||
| and "Transform" in structured_template.keys() |
There was a problem hiding this comment.
Question: we certain the capability is only meant for Global Transformation, or can it be a limiting factor when using Local Transformations and macros?
There was a problem hiding this comment.
It is also required for macros as well. This is the implementation in the old provider, so if we are not in parity there we are not in parity either, and have not been in parity for a long time!
pinzon
left a comment
pinzon
left a comment
There was a problem hiding this comment.
Thanks for addressing my question 👍
Motivation
When creating a stack with transforms, the
CAPABILITY_AUTO_EXPANDcapability is required. This is not currently validated with the new engineChanges