Skip to content

CloudFormation v2 Engine: Base Support for Serverless Global Transforms #12742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MEPalma merged 3 commits into from
Jun 12, 2025
Merged

CloudFormation v2 Engine: Base Support for Serverless Global Transforms #12742

MEPalma merged 3 commits into from
Jun 12, 2025

Conversation

@MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Jun 11, 2025

Motivation

The introduction of the CloudFormation v2 engine laid the foundation for a redesigned engine capable of accurately determining update requirements between CloudFormation deployments, while also enabling parallel execution during updates. However, the current implementation does not support AWS::Serverless global transforms.

Changes

  • modeling support for updates to transform blocks
  • introduce new transform visitor to inductively apply global transforms to both versions of the template
  • port v1 logic for serverless global transforms
  • minor refactor of provider and stack entities
  • remove relevant CFNV2 test skips

Future Work

  • expand global transform support to macros (port from v1) and language extensions (in transform or preproc visitor class)
  • investigate the behavior for updates to transform blocks
  • other minors, see in-code TODO notes

@MEPalma MEPalma added this to the 4.6 milestone Jun 11, 2025
@MEPalma MEPalma requested a review from simonrw June 11, 2025 13:27
@MEPalma MEPalma self-assigned this Jun 11, 2025
@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jun 11, 2025
@github-actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 613 tests  ±0   19 958 ✅ ±0   6m 9s ⏱️ -2s
     1 suites ±0    1 655 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 27421dc. ± Comparison against base commit 75c84f6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 27421dc. ± Comparison against base commit 75c84f6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   20m 52s ⏱️ - 1h 22m 0s
885 tests  - 3 987  319 ✅  - 3 776  566 💤  - 211  0 ❌ ±0 
887 runs   - 3 987  319 ✅  - 3 776  568 💤  - 211  0 ❌ ±0 

Results for commit 27421dc. ± Comparison against base commit 75c84f6.

This pull request removes 3987 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   33m 18s ⏱️
909 tests 344 ✅ 565 💤 0 ❌
915 runs  344 ✅ 571 💤 0 ❌

Results for commit 27421dc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

Test Results - Alternative Providers

987 tests   589 ✅  30m 6s ⏱️
  4 suites  398 💤
  4 files      0 ❌

Results for commit 27421dc.

♻️ This comment has been updated with latest results.

simonrw
simonrw approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We pair reviewed an earlier version of this. Nice clean changes thanks!

@MEPalma MEPalma merged commit 3bbf944 into master Jun 12, 2025
40 checks passed
@MEPalma MEPalma deleted the MEP-CFN-serverless_transforms branch June 12, 2025 06:59
@simonrw simonrw mentioned this pull request Sep 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonrw simonrw simonrw approved these changes

Assignees

@MEPalma MEPalma

Labels

semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

3 participants

@MEPalma @simonrw