CloudFormation v2 Engine: Base Support for Fn::And Fn::Or and Condition Bindings #12706
Conversation
MEPalma
added
the
semver: minor
LocalStack Community integration with Pro 2 files 2 suites 21m 50s ⏱️ Results for commit 46ea4b1. ♻️ This comment has been updated with latest results. |
Test Results - Alternative Providers987 tests 584 ✅ 23m 7s ⏱️ Results for commit 46ea4b1. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 33m 17s ⏱️ Results for commit 46ea4b1. ♻️ This comment has been updated with latest results. |
|
|
||
| aws_client.sns.get_topic_attributes(TopicArn=topic_arn) | ||
|
|
||
| # @pytest.mark.skip(reason="CFNV2:Mappings") |
| @pytest.mark.skip(reason="CFNV2:ReferenceDotSyntax") | ||
| @pytest.mark.skip( | ||
| reason="CFNV2:Other resource name conflict with another test case resource in this suite" | ||
| ) |
There was a problem hiding this comment.
I guess because the deletion is not implemented yet, so we are leaving resources lying around.
|
|
||
|
|
||
| @pytest.mark.skip(reason="CFNV2:ReferenceDotSyntax") | ||
| @pytest.mark.skip(reason="CFNV2:Other") |
There was a problem hiding this comment.
nit: it would be nice when classifying skips as "Other" to add a little more detail (as you do above) on the actual failure, so we can look for common patterns.
Motivation
The introduction of the CloudFormation v2 engine laid the foundation for a redesigned engine capable of accurately determining update requirements between CloudFormation deployments, while also enabling parallel execution during updates. However, the current implementation does not support
Fn::And,Fn::Or, nor{"Condition": "<identifer>"}bindings.Changes
Fn::And,Fn::Or, and condition bindings