Skip to content

add testing for Fn::Transform in CFn v2 #12689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonrw merged 27 commits into from
Aug 5, 2025
Merged

add testing for Fn::Transform in CFn v2 #12689

simonrw merged 27 commits into from
Aug 5, 2025

Conversation

@pinzon
Copy link
Member

@pinzon pinzon commented May 29, 2025 •
edited
Loading

Motivation

This PR adds a collection of tests to validate the behavior of intrinsic transformation in a template. The tests are due to be unskipped when the feature is implemented in another PR.

Testing

  • New AWS validated tests to confirm that the function works with change sets.

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 984 tests  ±0   20 250 ✅ ±0   6m 23s ⏱️ ±0s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit f343b22. ± Comparison against base commit f5d850d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 17s ⏱️ +10s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit f343b22. ± Comparison against base commit f5d850d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

Test Results - Alternative Providers

1 000 tests  +12   625 ✅ +4   36m 51s ⏱️ + 3m 4s
    4 suites ± 0   366 💤  - 1 
    4 files   ± 0     9 ❌ +9 

For more details on these failures, see this check.

Results for commit e3384dd. ± Comparison against base commit 6348947.

This pull request skips 4 and un-skips 5 tests. 
tests.aws.services.cloudformation.v2.ported_from_v1.api.test_changesets ‑ test_autoexpand_capability_requirement
tests.aws.services.cloudformation.v2.ported_from_v1.resources.test_stack_sets ‑ test_create_stack_set_with_stack_instances
tests.aws.services.cloudformation.v2.ported_from_v1.test_template_engine.TestMacros ‑ test_error_pass_macro_as_reference
tests.aws.services.cloudformation.v2.ported_from_v1.test_template_engine.TestMacros ‑ test_to_validate_template_limit_for_macro

tests.aws.services.cloudformation.v2.ported_from_v1.api.test_stacks.TestStacksApi ‑ test_update_stack_with_same_template_withoutchange
tests.aws.services.cloudformation.v2.ported_from_v1.api.test_templates ‑ test_create_stack_from_s3_template_url[http_host]
tests.aws.services.cloudformation.v2.ported_from_v1.api.test_templates ‑ test_create_stack_from_s3_template_url[http_invalid]
tests.aws.services.cloudformation.v2.ported_from_v1.api.test_templates ‑ test_create_stack_from_s3_template_url[http_path]
tests.aws.services.cloudformation.v2.ported_from_v1.api.test_templates ‑ test_create_stack_from_s3_template_url[s3_url]

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ± 0      2 suites  ±0   1h 44m 32s ⏱️ -48s
4 600 tests +14  4 176 ✅ ±0  424 💤 +14  0 ❌ ±0 
4 602 runs  +14  4 176 ✅ ±0  426 💤 +14  0 ❌ ±0 

Results for commit f343b22. ± Comparison against base commit f5d850d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 19m 8s ⏱️
4 959 tests 4 383 ✅ 576 💤 0 ❌
4 965 runs  4 383 ✅ 582 💤 0 ❌

Results for commit f343b22.

♻️ This comment has been updated with latest results.

@pinzon pinzon force-pushed the cfn/test/fn-transform-include branch 2 times, most recently from c450be1 to 7bd5f66 Compare June 2, 2025 15:45
@tiurin tiurin added this to the Playground milestone Jun 4, 2025
@pinzon pinzon force-pushed the cfn/test/fn-transform-include branch from 4aa21fe to 8b24925 Compare June 20, 2025 19:35
@pinzon pinzon force-pushed the cfn/test/fn-transform-include branch 3 times, most recently from 57aef60 to 6d9299d Compare July 2, 2025 18:09
@pinzon pinzon force-pushed the cfn/test/fn-transform-include branch from eee09b0 to a61e2bb Compare July 14, 2025 15:07
@pinzon pinzon changed the title wip: add tests for Fn::Transform in change sets add support for Fn::Transform in CFn v2 Jul 15, 2025
@pinzon pinzon added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jul 15, 2025
@pinzon pinzon force-pushed the cfn/test/fn-transform-include branch from 9b55a00 to 4b41da3 Compare July 17, 2025 14:40
@localstack-bot
Copy link
Contributor

localstack-bot commented Jul 17, 2025

Currently, only patch changes are allowed on main. Your PR labels (semver: minor) indicate that it cannot be merged into the main at this time.

@pinzon pinzon force-pushed the cfn/test/fn-transform-include branch from 4b41da3 to 2d78477 Compare July 29, 2025 17:48
@pinzon pinzon changed the title add support for Fn::Transform in CFn v2 add testing for Fn::Transform in CFn v2 Jul 29, 2025
@pinzon pinzon marked this pull request as ready for review July 29, 2025 18:03
@coveralls
Copy link

coveralls commented Jul 29, 2025 •
edited
Loading

Coverage Status

coverage: 86.085% (+34.7%) from 51.37%
when pulling eeb8622 on cfn/test/fn-transform-include
into 5535768 on main.

simonrw
simonrw reviewed Jul 30, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to add some tests that cover changing Fn::Transform usages, so it would exist in the first template, then the arguments change for the second template. WDYT?

@pinzon pinzon force-pushed the cfn/test/fn-transform-include branch from eeb8622 to d4b6580 Compare August 1, 2025 15:50
@pinzon pinzon requested a review from simonrw August 4, 2025 14:06
simonrw
simonrw approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for capturing these tests, I'm excited to see what the implementation will be in the future!

I am not super keen on adding skips to the test suite, I would have expected this PR to be purely additive, however we are going to overhaul it so maybe starting from scratch is a good idea.

@simonrw simonrw merged commit 6e03b92 into main Aug 5, 2025
40 checks passed
@simonrw simonrw deleted the cfn/test/fn-transform-include branch August 5, 2025 09:40
@simonrw simonrw mentioned this pull request Aug 5, 2025
Merged
@simonrw simonrw mentioned this pull request Sep 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonrw simonrw simonrw approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

Playground

Development

Successfully merging this pull request may close these issues.

6 participants

@pinzon @localstack-bot @coveralls @simonrw @tiurin