CFn v2: support outputs #12536
CFn v2: support outputs #12536
Conversation
simonrw
added
aws:cloudformation
simonrw
force-pushed
the
cfn/v2/executor/support-outputs
branch
from
484cf82 to
451f836
Compare
LocalStack Community integration with Pro 2 files 2 suites 20m 47s ⏱️ Results for commit 271ec4c. ♻️ This comment has been updated with latest results. |
simonrw
force-pushed
the
cfn/v2/executor/support-outputs
branch
2 times, most recently
from
6b187b5 to
b07c444
Compare
There was a problem hiding this comment.
Thank you, it looks very good!
Aside from a couple of nits for future consideration, I see some tests in localstack/tests/aws/services/cloudformation/v2 failing due to the v2 returning empty Outputs fields; perhaps we can address this detail in this PR?
| "Outputs": [ | ||
| # TODO(parity): Description, ExportName | ||
| # TODO(parity): what happens on describe stack when the stack has not been deployed yet? | ||
| {"OutputKey": k, "OutputValue": v} |
There was a problem hiding this comment.
We could instantiate these as localstack.aws.api.cloudformation.Output
|
|
||
| @dataclass | ||
| class ChangeSetModelExecutorResult: | ||
| resources: dict |
There was a problem hiding this comment.
Moving forward we could think of typing these
There was a problem hiding this comment.
I want to do a proper typing pass when everything has settled 👍 A big issue with the old provider is lack of types
simonrw
force-pushed
the
cfn/v2/executor/support-outputs
branch
from
b07c444 to
b111505
Compare
Motivation
Currently the preprocessor supports evaluating outputs, but the executor does not use these values.
Changes
executemethod to return a structured value which includes the stack outputs