Skip to content

Conversation

@MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Apr 16, 2025

Motivation

This PR resolves several issues in the Engine V2 provider related to template delta handling and reference evaluation. Specifically, it addresses:

  • Misinterpretation of deltas in templates where property definitions are empty or missing
  • Faulty comparison logic in preprocessor delta conditions, where the absence of a condition was incorrectly treated as a match
  • Limited handling of reference evaluation when a physical ID changes during updates
  • Additional minor issues and inconsistencies

Changes

  • Fixed misinterpretation of deltas in templates with empty/missing properties
  • Corrected logic for comparing preprocessor delta conditions
  • Improved handling of Ref evaluation across physical ID changes
  • Fixed the lack of describe and execution pruning for unchanged resources
  • Addressed various minor issues

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Apr 16, 2025
@MEPalma MEPalma added this to the 4.4 milestone Apr 16, 2025
@MEPalma MEPalma self-assigned this Apr 16, 2025
@github-actions
Copy link

LocalStack Community integration with Pro

  2 files    2 suites   21m 39s ⏱️
463 tests 314 ✅ 149 💤 0 ❌
465 runs  314 ✅ 151 💤 0 ❌

Results for commit 11ccec3.

Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one thanks for fixing my hacks and the tests!

@MEPalma MEPalma merged commit 2069add into master Apr 17, 2025
34 checks passed
@MEPalma MEPalma deleted the MEP-CFN-fix_ref_resolution_and_comparisons branch April 17, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants