Skip to content

chore: improve test snapshot #12367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
giograno merged 1 commit into from
Mar 11, 2025
Merged

chore: improve test snapshot #12367

giograno merged 1 commit into from
Mar 11, 2025

Conversation

@giograno
Copy link
Member

@giograno giograno commented Mar 11, 2025

Motivation

When snapshotting an exception, the best practice is to snapshot the actual response of the exception, instead of the ExceptionInfo object. In this way we can capture the proper code, message, and status code.
In addition, the test becomes more stable (e.g., here the test fails for a different traceback level).

Changes

  • Improve the snapshot as described.

@giograno giograno added the semver: patch Non-breaking changes which can be included in patch releases label Mar 11, 2025
@giograno giograno requested a review from silv-io March 11, 2025 17:17
@giograno giograno marked this pull request as ready for review March 11, 2025 17:18
silv-io
silv-io approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for the quick turnaround 🚀

@github-actions
Copy link

github-actions bot commented Mar 11, 2025

LocalStack Community integration with Pro

 2 files  ±    0   2 suites  ±0   30s ⏱️ - 1h 53m 46s
21 tests  - 4 104  19 ✅  - 3 786  2 💤  - 318  0 ❌ ±0 
23 runs   - 4 104  19 ✅  - 3 786  4 💤  - 318  0 ❌ ±0 

Results for commit 1caa831. ± Comparison against base commit da04939.

This pull request removes 4104 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@giograno giograno merged commit 4f210f8 into master Mar 11, 2025
34 checks passed
@giograno giograno deleted the chore-improve-snapshot branch March 11, 2025 17:46
@giograno giograno mentioned this pull request Mar 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silv-io silv-io silv-io approved these changes

@macnev2013 macnev2013 Awaiting requested review from macnev2013

@sannya-singal sannya-singal Awaiting requested review from sannya-singal

Assignees

No one assigned

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giograno @silv-io