This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Merged
Conversation
bentsku
added
semver: patch
bentsku
requested review from
dfangl,
dominikschubert,
gregfurman and
joe4dev
as code owners
2 tasks
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 1h 28m 51s ⏱️ - 22m 8s Results for commit 22ae4f0. ± Comparison against base commit 892eb4d. This pull request removes 946 tests. |
Member
|
Thank you very much @bentsku for this fix 💯 Weirdly, Kafka in Lambda ESM does indeed use a different event structure not properly reflected in the API.
Kafka Lambda ESM example: {
"eventSource": "SelfManagedKafka",
"bootstrapServers":"b-2.demo-cluster-1.a1bcde.c1.kafka.us-east-1.amazonaws.com:9092,b-1.demo-cluster-1.a1bcde.c1.kafka.us-east-1.amazonaws.com:9092",
"records":{
"mytopic-0":[
{
"topic":"mytopic",
"partition":0,
"offset":15,
"timestamp":1545084650987,
"timestampType":"CREATE_TIME",
"key":"abcDEFghiJKLmnoPQRstuVWXyz1234==",
"value":"SGVsbG8sIHRoaXMgaXMgYSB0ZXN0Lg==",
"headers":[
{
"headerKey":[
104,
101,
97,
100,
101,
114,
86,
97,
108,
117,
101
]
}
]
}
]
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It seems #11883 has broken downstream dependencies, related to Kafka not having the same format (sending a dict when the signature is
list[dict]). Tests are failing and are not validated against AWS, so I suppose we're supposed to be able to acceptdictdirectly toprocess_events_batchasinput_events.Changes
first_event