This repository was archived by the owner on Mar 23, 2026. It is now read-only.
StepFunctions: Support for ContextObject Paths Bindings for ErrorPath and CausePath#11958
Merged
StepFunctions: Support for ContextObject Paths Bindings for ErrorPath and CausePath#11958
Conversation
MEPalma
added
the
semver: patch
MEPalma
requested review from
dominikschubert,
gregfurman and
joe4dev
as code owners
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 34m 32s ⏱️ - 1h 16m 27s Results for commit 7271645. ± Comparison against base commit 892eb4d. This pull request removes 2512 and adds 1 tests. Note that renamed tests count towards both. |
gregfurman
approved these changes
Nov 29, 2024
Contributor
gregfurman
left a comment
gregfurman
left a comment
There was a problem hiding this comment.
LGTM! Curious if we have any other productions that should support ContextObject path bindings 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The SFN v2 interpreter does not support ContextObject bindings for ErrorPath and CausePath fields, which leads to parse errors when these are defined: #11950. These changes add the relvant grammar and eval support.
Changes
Future work
As we accumulate more snapshot tests, a pattern is emerging in the evaluation logic that we should consider. We should explore introducing a reusable string evaluation expression into the grammar, capable of handling the parsing and evaluation of string literals, JSONPaths, context object paths, variables, and JSONata expressions. By incorporating preprocessing safeguards against invalid bindings, this approach could streamline the grammar, reduce its size, and eliminate some of the evaluation duplications introduced by these changes.