This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Handle null value in SES OpenAPI spec#11954
Merged
HarshCasper merged 2 commits intomasterfrom Nov 29, 2024
Merged
Conversation
giograno
added
the
semver: patch
Member
viren-nadkarni
left a comment
viren-nadkarni
left a comment
There was a problem hiding this comment.
Thanks for fixing this.
Small ask: could you also update the class definition in localstack.services.ses.models before merging?
HarshCasper
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a minor gap in our SES OpenAPI specs.
In particular, the
htlm_partproperty in the response toGET /_aws/sescan benull.This issue was detected by @HarshCasper when using the SDK generated from the spec (as the generated Pydantic model does not expect a null value).
Changes
html_partto nullable in the specs.