This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Conversation
bentsku
added
aws:ses
alexrashed
approved these changes
Nov 27, 2024
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Nice catch! Thanks for jumping on this! 🚀
LocalStack Community integration with Pro 2 files 2 suites 2m 37s ⏱️ Results for commit 2a945e5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Following #11930, we were sending SES emails via SNS, and it incremented the counter. However, we were snapshotting the initial value to
0.0, which is then sensitive to test run orders and such.The test needs fixing in AWS, but I've manually run the update snapshot with only the initial part of the test to still validate the proper format of
GetSendQuotafrom AWS.The behavior of the test is still correctly validated via asserts (not working in AWS, probably because of sandbox account).
Changes