Conversation
localstack-bot
added
area: asf
area: dependencies
localstack-bot
requested review from
bentsku,
macnev2013 and
viren-nadkarni
as code owners
|
@alexrashed I've manually trigger an ASF update as it is needed for #11941 which can go in the release, it's a minor feature that is needed to unblock other open source projects as they are using LocalStack in CI, and they'd like to make use of that feature as well. @dominikschubert had given a green light for this minor/patch change to go in I've manually ran the downstream dependencies actions, and there are no changes to be reported. (AWS / Update ASF APIs #\23) As a side note, I'm a bit sad I wasn't quicker because when I started to implement the feature earlier today, |
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 4m 10s ⏱️ Results for commit 8ca9935. |
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Thanks for the explanation, @bentsku! And thanks for taking the initiative and just run the action to get the latest updates in! That's exactly how it's intended to be used! 🚀
I retriggered the pipeline, but in fact I'll just move forward with the merge since the failing tests were just flakes.
We only need to make sure that we also update the dependencies in our downstream project afterwards, because this PR updates and exact pin of botocore (and therefore a transitive exact pin of our downstream project).
3 participants
🚀 ASF Update Report 🚀
This PR has been automatically generated to update the generated API stubs for our ASF services.
It uses the latest code-generator from the master branch (scaffold.py) and the latest published version of botocore to re-generate all API stubs which are already present in the
localstack.aws.apimodule of the master branch.🔄 Updated Services
This PR updates the following services:
👷🏽 Handle this PR
The following options describe how to interact with this PR / the auto-update:
✔️ Accept Changes
If the changes are satisfying, just squash-merge the PR and delete the source branch.
🚫 Ignore Changes
If you want to ignore the changes in this PR, just close the PR and do not delete the source branch. The PR will not be opened and a new PR will not be created for as long as the generated code does not change (or the branch is deleted). As soon as there are new changes, a new PR will be created.
✏️ Adapt Changes
Don't do this. The APIs are auto-generated. If you decide that the APIs should look different, you have to change the code-generation.
⏸️ Pause Updates
Remove the cron-schedule trigger of the GitHub Action workflow which creates these PRs. The action can then still be triggered manually, but it will not be executed automatically.