This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Add UsageMultiSetCounter (up for discussion)#11934
Closed
Conversation
Member
Author
|
Superseeded by new structured metric counters #12230 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #11883
Motivation
Our current
UsageSetCountercan record events of different categories (i.e., set), but cannot record multi-dimensional data (e.g., source, target). This PR contains a possible implementation for a two-dimensional multi-set counter.We decided not to move forward with this approach until the data requirements are clearer (e.g., allow for generic analysis/materialization rather than feature-specific solutions that don't scale). Therefore, this PR is parked for now and up for discussion.
Discussion
The flat record structure (
pipes:invocation:aws:sqs) is not ideal and would be cumbersome to analyze.Something like this might be more suitable, but still not ideal if the namespace is feature-specific:
{"outer_namespace": {"inner_namespace": {"key": "count"}}}Changes
UsageMultiSetCountertest_multi_set_counter