This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Conversation
bentsku
added
aws:sns
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 4m 9s ⏱️ Results for commit 9a68e04. ♻️ This comment has been updated with latest results. |
alexrashed
approved these changes
Nov 26, 2024
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
LGTM! 💯 Nice and clean, would be great to have a test though, but that could also be added in a later iteration (not blocking). 😉
alexrashed
approved these changes
Nov 26, 2024
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Awesome! Thanks for addressing the comment right away and adding a test! 🚀 💯 
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As reported by @HarshCasper, the sender of SNS email notifications was hardcoded to
[email protected]with no mean of changing that. We should replace this value by something like[email protected]or something similar, as AWS is sending those notifications with[email protected].I'm a bit worried about changing this directly however, as some users might expected and test that emails are arriving from that sender.
Changes
SNS_SES_SENDER_ADDRESSconfig variable to make it configurable, and fallback to[email protected]if not configuredTODO
What's left to do: