This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Merged
Conversation
joe4dev
added
the
semver: patch
dominikschubert
approved these changes
Nov 27, 2024
Member
dominikschubert
left a comment
dominikschubert
left a comment
There was a problem hiding this comment.
LGTM, ideally not gonna be necessary though if we can phase out the java one 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #11807
Motivation
We are missing analytics tracking for the event ruler and a plugins.py to make the package installable (if we decide to ship it). Currently, we don't see the need for shipping it as the Java-based event ruler is opt-in.
Changes
EVENT_RULE_ENGINEevent-rulerpackage installable (in case we need to ship it to unblock users facing dynamic installation issues)