Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

fix(providers): Removed cloudcontrol provider#11920

Merged
Pive01 merged 1 commit intomasterfrom
cloudcontorl-cleanup
Nov 25, 2024
Merged

fix(providers): Removed cloudcontrol provider#11920
Pive01 merged 1 commit intomasterfrom
cloudcontorl-cleanup

Conversation

@Pive01
Copy link
Copy Markdown
Contributor

@Pive01 Pive01 commented Nov 25, 2024

Motivation

Removed cloudcontrol provider for community as we moved it in pro

Changes

Removed cloudcontrol from the list of community providers

@Pive01 Pive01 added the semver: patch Non-breaking changes which can be included in patch releases label Nov 25, 2024
@Pive01 Pive01 requested review from silv-io and simonrw November 25, 2024 10:09
silv-io
silv-io approved these changes Nov 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the code in localstack.services.cloudcontrol.provider also migrated to PRO?

If yes, then it's alright. Otherwise we'd have to take a look at that as well before merging

@Pive01
Copy link
Copy Markdown
Contributor Author

Pive01 commented Nov 25, 2024

Is the code in localstack.services.cloudcontrol.provider also migrated to PRO?

If yes, then it's alright. Otherwise we'd have to take a look at that as well before merging

Yes, everything has been moved here

@silv-io
Copy link
Copy Markdown
Member

silv-io commented Nov 25, 2024

Is the code in localstack.services.cloudcontrol.provider also migrated to PRO?
If yes, then it's alright. Otherwise we'd have to take a look at that as well before merging

Yes, everything has been moved here

In that PR I can only see it being added to pro, but where was that removed from community?

@Pive01
Copy link
Copy Markdown
Contributor Author

Pive01 commented Nov 25, 2024

Is the code in localstack.services.cloudcontrol.provider also migrated to PRO?
If yes, then it's alright. Otherwise we'd have to take a look at that as well before merging

Yes, everything has been moved here

In that PR I can only see it being added to pro, but where was that removed from community?

Was never added in the first time, initially was added but half way through we moved it

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 25, 2024

LocalStack Community integration with Pro

    2 files      2 suites   1h 48m 9s ⏱️
3 724 tests 3 377 ✅ 347 💤 0 ❌
3 726 runs  3 377 ✅ 349 💤 0 ❌

Results for commit 1da2503.

@Pive01 Pive01 merged commit 08ad92b into master Nov 25, 2024
@Pive01 Pive01 deleted the cloudcontorl-cleanup branch November 25, 2024 11:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@simonrw simonrw simonrw approved these changes

@silv-io silv-io silv-io approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pive01 @silv-io @simonrw