This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Merged
Conversation
macnev2013
requested review from
alexrashed and
viren-nadkarni
and removed request for
alexrashed
macnev2013
added
the
semver: patch
Member
viren-nadkarni
left a comment
viren-nadkarni
left a comment
There was a problem hiding this comment.
Mac JRE builds seem to have a different file tree altogether. Have you checked if the paths on line 70 and 72 for example are valid with this change?
Contributor
Author
|
Yes @viren-nadkarni, Since we've directly updated the JAVA_HOME, all the variables are updated accordingly. e.g: For |
viren-nadkarni
approved these changes
Nov 21, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow up PR to #11888 (comment). @maxhoheiser reported a bug where java lib path was not properly generated.
Thanks @maxhoheiser for reporting.
Changes
/Contents/Homesince it's already included in the java home.