This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Merged
Conversation
macnev2013
requested review from
viren-nadkarni
and removed request for
alexrashed
macnev2013
added
the
semver: patch
viren-nadkarni
approved these changes
Nov 21, 2024
Member
viren-nadkarni
left a comment
viren-nadkarni
left a comment
There was a problem hiding this comment.
LGTM, thanks for improving the devx in Mac OS ✔️
Contributor
|
For me, it worked before the patch - and with the patch, it introduces a double nesting like so: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR resolves the issue with Java home retrieval on macOS. For the temurin Java distribution, the Java home directory on macOS resides in /Contents/Home. This discrepancy caused errors in big data services when running in host mode.
Changes
Updated the logic for Java home retrieval on macOS to accommodate the temurin distribution structure.