This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Merged
Conversation
cloutierMat
added
aws:apigateway
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 43m 38s ⏱️ +5s Results for commit 92d8bd5. ± Comparison against base commit ad1af78. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. |
Member
Author
|
@simonrw I added you here as it directly impacts appsync 😉 |
simonrw
approved these changes
Nov 20, 2024
Contributor
simonrw
left a comment
simonrw
left a comment
There was a problem hiding this comment.
Great change, thank you for making a clean implementation on being able to dispatch between AppSync and API Gateway behaviour!
bentsku
approved these changes
Nov 20, 2024
Contributor
bentsku
left a comment
bentsku
left a comment
There was a problem hiding this comment.
LGTM! Neat fix, thanks for updating and validating the test! Glad that it still caught a possible regression... 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While investigating the issue reported by #11843, I noticed that the default returned value of unfound variables differs between apigateway and appsync. We had this patch working for apigateway, but it would unfortunately fail some appsync functions that are expecting to receive a null value.
Changes
prepare_namespaceto allow setting asource.fixes #11843