remove s3 legacy provider #11746
Merged
remove s3 legacy provider #11746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:s3
Contributor
|
Currently, only minor and patch changes are allowed on master. Your PR labels (aws:s3, semver: major) indicate that it cannot be merged into the master at this time. |
bentsku
force-pushed
the
remove-s3-legacy
branch
from
93c661a to
6b60f35
Compare
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 31s ⏱️ Results for commit 6662509. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 42m 22s ⏱️ - 2m 52s Results for commit 6662509. ± Comparison against base commit fb7cde9. This pull request removes 2 tests.♻️ This comment has been updated with latest results. |
bentsku
force-pushed
the
remove-s3-legacy
branch
2 times, most recently
from
f222411 to
8bdcfb9
Compare
bentsku
force-pushed
the
remove-s3-legacy
branch
from
8bdcfb9 to
6662509
Compare
bentsku
requested review from
alexrashed,
dominikschubert and
thrau
as code owners
alexrashed
approved these changes
Oct 31, 2024
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Nice and clean deletion of the old S3 provider. 🧹 💯
bentsku
added a commit
that referenced
this pull request
Oct 31, 2024
joe4dev
pushed a commit
that referenced
this pull request
Nov 5, 2024
dfangl
pushed a commit
that referenced
this pull request
Nov 6, 2024
alexrashed
pushed a commit
that referenced
this pull request
Nov 8, 2024
joe4dev
pushed a commit
that referenced
this pull request
Nov 12, 2024
dfangl
pushed a commit
that referenced
this pull request
Nov 14, 2024
dominikschubert
pushed a commit
that referenced
this pull request
Nov 14, 2024
dominikschubert
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
S3 v3 (fully native in LocalStack) has been the default since v3, and we deprecated and did not maintain the legacy v2 implementation and did not provide new features to it since then.
For the v4 release, we are removing the implementation and the associated tests.
Changes