As this piece of code gets duplicated a few times, I would suggest to create a separate utility fixture to create the firewall rule and pass the arguments for Priority and Action which would additionally also cleanup the resources.

Let me know if you require more inputs here, happy to help (you can find several references for this in the core repository itself 🙂)

Created a new fixture for this. Thanks!

nit: can this regex be used with the transformer directly?

Something like:

Done.

nit:

nit: As suggested above, the cleanups should be as close to the thing they are cleaning up as possible. In this case, not a lot will go wrong with the snapshot.match function, however... 😂

Thank you!
Done.

This test executes a combination of two variables: Priority and Action. Since there are a small number of reasonable combinations, I don't think it's too hard to get coverage over all of the combinations

Is it worth adding a loop to cover this table? It might make the test a bit shorter as well, with less repetition. You should also then test not including one or both of the priority and action.

This is the beauty of snapshot tests: asserting that the result is correct is easy, compared to asserting this behaviour by hand.

I was trying to keep the tests explicit (the Tests should not be clever principle).

nit: Since we do not collect any response here, we can directly remove the left hand side and write aws_client.route53resolver.create_firewall_rule(...)

We can just have a fixture for create_firewall_rule and cleanups since it was duplicated a lot of times and call it from the test itself for different params. This will be helpful in re-using this fixture even outside of this test 🙂

Also we can remove adding a scope as it falls to this default value 😉 and just a nit: we can remove the route53resolver prefix in the name of the fixture.

def create_firewall_rule(self, aws_client, ..):
    # create logic
    # yield the response
    # cleanup