Skip to content

Conversation

@dominikschubert
Copy link
Member

Motivation

Initially introduced into the legacy model with #8957

Users reported this was broken again, so I investigated and found that there was a small bug in the provider migration that caused this setting to never be passed to the API call.

Changes

  • Fix param selection for API call

@dominikschubert dominikschubert self-assigned this Feb 29, 2024
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Feb 29, 2024
Copy link
Contributor

@Morijarti Morijarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM

@coveralls
Copy link

Coverage Status

coverage: 83.825% (+0.01%) from 83.812%
when pulling 02ddfa2 on fix-cfn-ec2-userdata
into 307cbe9 on master.

@dominikschubert dominikschubert marked this pull request as ready for review February 29, 2024 15:40
@github-actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 28m 25s ⏱️ -10s
2 667 tests ±0  2 418 ✅ ±0  249 💤 ±0  0 ❌ ±0 
2 669 runs  ±0  2 418 ✅ ±0  251 💤 ±0  0 ❌ ±0 

Results for commit 02ddfa2. ± Comparison against base commit 307cbe9.

@dominikschubert dominikschubert merged commit 4754a2d into master Feb 29, 2024
@dominikschubert dominikschubert deleted the fix-cfn-ec2-userdata branch February 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants