suppress warning for the CI env var

alexrashed · alexrashed · commit ff88024e9a90 · 2024-11-19T16:29:16.000+01:00
diff --git a/localstack-core/localstack/utils/bootstrap.py b/localstack-core/localstack/utils/bootstrap.py
@@ -516,9 +516,14 @@ def config_env_vars(cfg: ContainerConfiguration):
         for env_var in config.CONFIG_ENV_VARS:
             value = os.environ.get(env_var, None)
             if value is not None:
-                if not env_var.startswith("LOCALSTACK_") and env_var not in profile_env:
+                if (
+                    env_var != "CI"
+                    and not env_var.startswith("LOCALSTACK_")
+                    and env_var not in profile_env
+                ):
                     # Show a warning here in case we are directly forwarding an environment variable from
                     # the system env to the container which has not been prefixed with LOCALSTACK_.
+                    # Suppress the warning for the "CI" env var.
                     # Suppress the warning if the env var was set from the profile.
                     LOG.warning(
                         "Non-prefixed environment variable %(env_var)s is forwarded to the LocalStack container! "
diff --git a/tests/bootstrap/test_container_configurators.py b/tests/bootstrap/test_container_configurators.py
@@ -191,6 +191,19 @@ def test_container_configurator_no_deprecation_warning_on_prefix(
     assert "LOCALSTACK_SERVICES" in container.config.env_vars
 
 
+def test_container_configurator_no_deprecation_warning_for_CI_env_var(
+    container_factory, monkeypatch, caplog
+):
+    # set the "CI" env var indicating that we are running in a CI environment
+    monkeypatch.setenv("CI", "1")
+
+    container: Container = container_factory()
+    configure_container(container)
+
+    assert "Non-prefixed environment variable" not in caplog.text
+    assert "CI" in container.config.env_vars
+
+
 def test_container_configurator_no_deprecation_warning_on_profile(
     container_factory, monkeypatch, caplog, tmp_path
 ):
