work in review suggestions

baermat · baermat · commit ef8623e6d9cf · 2025-10-15T13:52:25.000+02:00
diff --git a/localstack-core/localstack/services/sns/v2/provider.py b/localstack-core/localstack/services/sns/v2/provider.py
@@ -58,7 +58,7 @@ def create_topic(
                 if not attrs.get(k) or not attrs.get(k) == v:
                     # TODO:
                     raise InvalidParameterException("Fix this Exception message and type")
-            tag_resource_success = extract_tags(topic_arn, tags, True, store)
+            tag_resource_success = _check_matching_tags(topic_arn, tags, store)
             if not tag_resource_success:
                 raise InvalidParameterException(
                     "Invalid parameter: Tags Reason: Topic already exists with different tags"
@@ -253,10 +253,14 @@ def _create_default_topic_policy(topic: Topic, context: RequestContext) -> str:
     )
 
 
-# TODO: move this to utils after rebase
-def extract_tags(
-    topic_arn: str, tags: TagList, is_create_topic_request: bool, store: SnsStore
-) -> bool:
+def _check_matching_tags(topic_arn: str, tags: TagList | None, store: SnsStore) -> bool:
+    """
+    Checks if a topic to be created doesn't already exist with different tags
+    :param topic_arn: Arn of the topic
+    :param tags: Tags to be checked
+    :param store: Store object that holds the topics and tags
+    :return: False if there is a mismatch in tags, True otherwise
+    """
     existing_tags = store.TAGS.list_tags_for_resource(topic_arn)["Tags"]
     # if this is none there is nothing to check
     if topic_arn in store.topics:
@@ -265,6 +269,6 @@ def extract_tags(
         for tag in tags:
             # this means topic already created with empty tags and when we try to create it
             # again with other tag value then it should fail according to aws documentation.
-            if is_create_topic_request and existing_tags is not None and tag not in existing_tags:
+            if existing_tags is not None and tag not in existing_tags:
                 return False
     return True
