same validation for stack update

pinzon · pinzon · commit c7d27b16e64f · 2025-10-10T16:46:50.000-05:00
diff --git a/localstack-core/localstack/services/cloudformation/v2/provider.py b/localstack-core/localstack/services/cloudformation/v2/provider.py
@@ -1542,6 +1542,14 @@ def update_stack(
                 raise RuntimeError("Multiple stacks matched, update matching logic")
             stack = active_stack_candidates[0]
 
+        if (
+            stack.status == StackStatus.DELETE_COMPLETE
+            or stack.status == StackStatus.DELETE_IN_PROGRESS
+        ):
+            raise ValidationError(
+                f"Stack:{stack.stack_id} is in {stack.status} state and can not be updated."
+            )
+
         # TODO: proper status modeling
         before_parameters = stack.resolved_parameters
         # TODO: reconsider the way parameters are modelled in the update graph process.
diff --git a/tests/aws/services/cloudformation/api/test_update_stack.py b/tests/aws/services/cloudformation/api/test_update_stack.py
@@ -5,6 +5,7 @@
 import botocore.errorfactory
 import botocore.exceptions
 import pytest
+from tests.aws.services.cloudformation.conftest import skip_if_legacy_engine
 
 from localstack.testing.pytest import markers
 from localstack.utils.files import load_file
@@ -459,3 +460,32 @@ def test_diff_after_update(deploy_cfn_template, aws_client, snapshot):
 
     describe_stack_response = aws_client.cloudformation.describe_stacks(StackName=stack.stack_name)
     assert describe_stack_response["Stacks"][0]["StackStatus"] == "UPDATE_COMPLETE"
+
+
+@markers.aws.validated
+@skip_if_legacy_engine
+def test_update_deleted_stack(aws_client, deploy_cfn_template, snapshot):
+    template = json.dumps(
+        {
+            "Resources": {
+                "Parameter": {
+                    "Type": "AWS::SSM::Parameter",
+                    "Properties": {"Type": "String", "Value": "Test"},
+                }
+            }
+        }
+    )
+
+    stack = deploy_cfn_template(template=template)
+    stack.destroy()
+
+    with pytest.raises(botocore.exceptions.ClientError) as ex:
+        aws_client.cloudformation.create_change_set(
+            StackName=stack.stack_id,
+            ChangeSetName="test",
+            TemplateBody=template,
+            ChangeSetType="UPDATE",
+        )
+
+    snapshot.add_transformer(snapshot.transform.regex(stack.stack_id, "<stack-id>"))
+    snapshot.match("Error", ex.value.response)
diff --git a/tests/aws/services/cloudformation/api/test_update_stack.snapshot.json b/tests/aws/services/cloudformation/api/test_update_stack.snapshot.json
@@ -186,5 +186,21 @@
         }
       }
     }
+  },
+  "tests/aws/services/cloudformation/api/test_update_stack.py::test_update_deleted_stack": {
+    "recorded-date": "10-10-2025, 21:42:05",
+    "recorded-content": {
+      "Error": {
+        "Error": {
+          "Code": "ValidationError",
+          "Message": "Stack:<stack-id> is in DELETE_COMPLETE state and can not be updated.",
+          "Type": "Sender"
+        },
+        "ResponseMetadata": {
+          "HTTPHeaders": {},
+          "HTTPStatusCode": 400
+        }
+      }
+    }
   }
 }
diff --git a/tests/aws/services/cloudformation/api/test_update_stack.validation.json b/tests/aws/services/cloudformation/api/test_update_stack.validation.json
@@ -8,6 +8,15 @@
   "tests/aws/services/cloudformation/api/test_update_stack.py::test_no_template_error": {
     "last_validated_date": "2022-11-21T07:57:45+00:00"
   },
+  "tests/aws/services/cloudformation/api/test_update_stack.py::test_update_deleted_stack": {
+    "last_validated_date": "2025-10-10T21:42:05+00:00",
+    "durations_in_seconds": {
+      "setup": 0.25,
+      "call": 18.99,
+      "teardown": 0.12,
+      "total": 19.36
+    }
+  },
   "tests/aws/services/cloudformation/api/test_update_stack.py::test_update_with_invalid_rollback_configuration_errors": {
     "last_validated_date": "2022-11-21T14:36:32+00:00"
   },

Original file line number	Diff line number	Diff line change
`@@ -186,5 +186,21 @@`
`186`	`186`	`}`
`187`	`187`	`}`
`188`	`188`	`}`
	`189`	`+ },`
	`190`	`+ "tests/aws/services/cloudformation/api/test_update_stack.py::test_update_deleted_stack": {`
	`191`	`+ "recorded-date": "10-10-2025, 21:42:05",`
	`192`	`+ "recorded-content": {`
	`193`	`+ "Error": {`
	`194`	`+ "Error": {`
	`195`	`+ "Code": "ValidationError",`
	`196`	`+ "Message": "Stack:<stack-id> is in DELETE_COMPLETE state and can not be updated.",`
	`197`	`+ "Type": "Sender"`
	`198`	`+ },`
	`199`	`+ "ResponseMetadata": {`
	`200`	`+ "HTTPHeaders": {},`
	`201`	`+ "HTTPStatusCode": 400`
	`202`	`+ }`
	`203`	`+ }`
	`204`	`+ }`
`189`	`205`	`}`
`190`	`206`	`}`