move create_default_topic_polocy

baermat · baermat · commit c2656fe541c2 · 2026-02-05T09:51:03.000+01:00
diff --git a/localstack-core/localstack/services/sns/provider.py b/localstack-core/localstack/services/sns/provider.py
@@ -120,6 +120,7 @@
     SnsPublishContext,
 )
 from localstack.services.sns.utils import (
+    create_default_topic_policy,
     create_platform_endpoint_arn,
     create_subscription_arn,
     encode_subscription_token_with_region,
@@ -1304,7 +1305,7 @@ def _default_attributes(topic: Topic, context: RequestContext) -> TopicAttribute
     default_attributes = {
         "DisplayName": "",
         "Owner": context.account_id,
-        "Policy": _create_default_topic_policy(topic["arn"]),
+        "Policy": create_default_topic_policy(topic["arn"]),
         "SubscriptionsConfirmed": "0",
         "SubscriptionsDeleted": "0",
         "SubscriptionsPending": "0",
@@ -1340,36 +1341,6 @@ def _create_default_effective_delivery_policy():
     )
 
 
-def _create_default_topic_policy(topic_arn: str) -> str:
-    return json.dumps(
-        {
-            "Version": "2008-10-17",
-            "Id": "__default_policy_ID",
-            "Statement": [
-                {
-                    "Effect": "Allow",
-                    "Sid": "__default_statement_ID",
-                    "Principal": {"AWS": "*"},
-                    "Action": [
-                        "SNS:GetTopicAttributes",
-                        "SNS:SetTopicAttributes",
-                        "SNS:AddPermission",
-                        "SNS:RemovePermission",
-                        "SNS:DeleteTopic",
-                        "SNS:Subscribe",
-                        "SNS:ListSubscriptionsByTopic",
-                        "SNS:Publish",
-                    ],
-                    "Resource": topic_arn,
-                    "Condition": {
-                        "StringEquals": {"AWS:SourceOwner": parse_arn(topic_arn)["account"]}
-                    },
-                }
-            ],
-        }
-    )
-
-
 def _validate_message_attributes(
     message_attributes: MessageAttributeMap, position: int | None = None
 ) -> None:
diff --git a/localstack-core/localstack/services/sns/resource_providers/aws_sns_topicpolicy.py b/localstack-core/localstack/services/sns/resource_providers/aws_sns_topicpolicy.py
@@ -14,7 +14,7 @@
     ResourceProvider,
     ResourceRequest,
 )
-from localstack.services.sns.provider import _create_default_topic_policy
+from localstack.services.sns.provider import create_default_topic_policy
 
 
 class SNSTopicPolicyProperties(TypedDict):
@@ -99,7 +99,7 @@ def delete(
                 sns.set_topic_attributes(
                     TopicArn=topic_arn,
                     AttributeName="Policy",
-                    AttributeValue=_create_default_topic_policy(topic_arn),
+                    AttributeValue=create_default_topic_policy(topic_arn),
                 )
 
             except ClientError as err:
diff --git a/localstack-core/localstack/services/sns/utils.py b/localstack-core/localstack/services/sns/utils.py
@@ -152,3 +152,33 @@ def get_topic_subscriptions(store: SnsStore, topic_arn: str) -> list[SnsSubscrip
 
     subscriptions = [store.subscriptions[k] for k in sub_arns if k in store.subscriptions]
     return subscriptions
+
+
+def create_default_topic_policy(topic_arn: str) -> str:
+    return json.dumps(
+        {
+            "Version": "2008-10-17",
+            "Id": "__default_policy_ID",
+            "Statement": [
+                {
+                    "Effect": "Allow",
+                    "Sid": "__default_statement_ID",
+                    "Principal": {"AWS": "*"},
+                    "Action": [
+                        "SNS:GetTopicAttributes",
+                        "SNS:SetTopicAttributes",
+                        "SNS:AddPermission",
+                        "SNS:RemovePermission",
+                        "SNS:DeleteTopic",
+                        "SNS:Subscribe",
+                        "SNS:ListSubscriptionsByTopic",
+                        "SNS:Publish",
+                    ],
+                    "Resource": topic_arn,
+                    "Condition": {
+                        "StringEquals": {"AWS:SourceOwner": parse_arn(topic_arn)["account"]}
+                    },
+                }
+            ],
+        }
+    )

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`ResourceProvider,`
`15`	`15`	`ResourceRequest,`
`16`	`16`	`)`
`17`		`-from localstack.services.sns.provider import _create_default_topic_policy`
	`17`	`+from localstack.services.sns.provider import create_default_topic_policy`
`18`	`18`
`19`	`19`
`20`	`20`	`class SNSTopicPolicyProperties(TypedDict):`
`@@ -99,7 +99,7 @@ def delete(`
`99`	`99`	`sns.set_topic_attributes(`
`100`	`100`	`TopicArn=topic_arn,`
`101`	`101`	`AttributeName="Policy",`
`102`		`- AttributeValue=_create_default_topic_policy(topic_arn),`
	`102`	`+ AttributeValue=create_default_topic_policy(topic_arn),`
`103`	`103`	`)`
`104`	`104`
`105`	`105`	`except ClientError as err:`