avoid installing dependencies in runner when LocalStack isn't running in process

bentsku · bentsku · commit b6fc84cab74f · 2026-02-04T13:51:56.000+01:00
diff --git a/localstack-core/localstack/testing/config.py b/localstack-core/localstack/testing/config.py
@@ -1,5 +1,6 @@
 import os
 
+from localstack.config import is_env_true
 from localstack.constants import DEFAULT_AWS_ACCOUNT_ID
 
 # Credentials used in the test suite
@@ -19,3 +20,6 @@
 SECONDARY_TEST_AWS_SECRET_ACCESS_KEY = os.getenv("SECONDARY_TEST_AWS_SECRET_ACCESS_KEY") or "test2"
 SECONDARY_TEST_AWS_SESSION_TOKEN = os.getenv("SECONDARY_TEST_AWS_SESSION_TOKEN")
 SECONDARY_TEST_AWS_REGION_NAME = os.getenv("SECONDARY_TEST_AWS_REGION_NAME") or "ap-southeast-1"
+
+TEST_SKIP_LOCALSTACK_START = is_env_true("TEST_SKIP_LOCALSTACK_START")
+TEST_FORCE_LOCALSTACK_START = is_env_true("TEST_FORCE_LOCALSTACK_START")
diff --git a/localstack-core/localstack/testing/pytest/in_memory_localstack.py b/localstack-core/localstack/testing/pytest/in_memory_localstack.py
@@ -21,8 +21,8 @@ def pytest_configure(config):
 from _pytest.config.argparsing import Parser
 from _pytest.main import Session
 
+import localstack.testing.config as test_config
 from localstack import config as localstack_config
-from localstack.config import is_env_true
 from localstack.constants import ENV_INTERNAL_TEST_RUN
 
 LOG = logging.getLogger(__name__)
@@ -53,12 +53,12 @@ def pytest_runtestloop(session: Session):
 
     from localstack.testing.aws.util import is_aws_cloud
 
-    if is_env_true("TEST_SKIP_LOCALSTACK_START"):
+    if test_config.TEST_SKIP_LOCALSTACK_START:
         LOG.info("TEST_SKIP_LOCALSTACK_START is set, not starting localstack")
         return
 
     if is_aws_cloud():
-        if not is_env_true("TEST_FORCE_LOCALSTACK_START"):
+        if not test_config.TEST_FORCE_LOCALSTACK_START:
             LOG.info("Test running against aws, not starting localstack")
             return
         LOG.info("TEST_FORCE_LOCALSTACK_START is set, a Localstack instance will be created.")
diff --git a/tests/aws/conftest.py b/tests/aws/conftest.py
@@ -7,6 +7,7 @@
 
 from localstack import config as localstack_config
 from localstack import constants
+from localstack.testing import config as test_config
 from localstack.testing.snapshots.transformer_utility import (
     SNAPSHOT_BASIC_TRANSFORMER,
     SNAPSHOT_BASIC_TRANSFORMER_NEW,
@@ -26,6 +27,26 @@ def pytest_configure(config: Config):
 
 
 def pytest_runtestloop(session):
+    """
+    This pytest plugin allows us to pre-install external dependencies that are usually lazy-loaded by the services.
+    This helps us surface download issues earlier.
+    This is not needed if we are running the test against an external instance, as it installs the dependencies on the
+    runner running the tests.
+    """
+    if not session.items:
+        return
+
+    if session.config.option.collectonly:
+        return
+
+    if test_config.TEST_SKIP_LOCALSTACK_START:
+        return
+
+    from localstack.testing.aws.util import is_aws_cloud
+
+    if is_aws_cloud() and not test_config.TEST_FORCE_LOCALSTACK_START:
+        return
+
     # second pytest lifecycle hook (before test runner starts)
     test_init_functions = set()
 
@@ -56,12 +77,6 @@ def pytest_runtestloop(session):
 
             test_init_functions.add(transcribe_install_async)
 
-    if not session.items:
-        return
-
-    if session.config.option.collectonly:
-        return
-
     for fn in test_init_functions:
         fn()
 
diff --git a/tests/aws/services/es/test_es.py b/tests/aws/services/es/test_es.py
@@ -11,6 +11,8 @@
     elasticsearch_package,
     opensearch_package,
 )
+from localstack.testing import config as test_config
+from localstack.testing.aws.util import is_aws_cloud
 from localstack.testing.pytest import markers
 from localstack.utils.common import safe_requests as requests
 from localstack.utils.common import short_uid, start_worker_thread
@@ -50,6 +52,10 @@ def run_install(*args):
 
 @pytest.fixture(autouse=True)
 def elasticsearch():
+    if is_aws_cloud() or test_config.TEST_SKIP_LOCALSTACK_START:
+        # we don't install the dependencies if LocalStack is not running in process
+        return
+
     if not installed.is_set():
         install_async()
 
diff --git a/tests/aws/services/opensearch/test_opensearch.py b/tests/aws/services/opensearch/test_opensearch.py
@@ -42,6 +42,7 @@
     OPENSEARCH_PLUGIN_LIST,
     opensearch_package,
 )
+from localstack.testing import config as test_config
 from localstack.testing.aws.util import is_aws_cloud
 from localstack.testing.pytest import markers
 from localstack.utils.common import call_safe, poll_condition, retry, short_uid, start_worker_thread
@@ -81,6 +82,10 @@ def run_install(*args):
 
 @pytest.fixture(autouse=True)
 def opensearch():
+    if is_aws_cloud() or test_config.TEST_SKIP_LOCALSTACK_START:
+        # we don't install the dependencies if LocalStack is not running in process
+        return
+
     if not installed.is_set():
         install_async()
 
diff --git a/tests/aws/services/transcribe/test_transcribe.py b/tests/aws/services/transcribe/test_transcribe.py
@@ -14,6 +14,7 @@
 from localstack.packages.ffmpeg import ffmpeg_package
 from localstack.services.transcribe.packages import vosk_package
 from localstack.services.transcribe.provider import LANGUAGE_MODELS, TranscribeProvider
+from localstack.testing import config as test_config
 from localstack.testing.aws.util import is_aws_cloud
 from localstack.testing.pytest import markers
 from localstack.utils.files import new_tmp_file
@@ -97,6 +98,10 @@ def transcribe_snapshot_transformer(snapshot):
 class TestTranscribe:
     @pytest.fixture(scope="class", autouse=True)
     def pre_install_dependencies(self):
+        if is_aws_cloud() or test_config.TEST_SKIP_LOCALSTACK_START:
+            # we don't install the dependencies if LocalStack is not running in process
+            return
+
         if not ffmpeg_installed.is_set() or not vosk_installed.is_set():
             install_async()
 
