fix: replace hardcoded region in SNS test (#13542)

baermat · web-flow · commit b613fb9acba5 · 2025-12-18T11:28:35.000+01:00
diff --git a/tests/aws/services/sns/test_sns.py b/tests/aws/services/sns/test_sns.py
@@ -609,7 +609,7 @@ def test_remove_permission_errors(self, snapshot, aws_client, account_id):
 
     @markers.aws.validated
     @pytest.mark.skipif(condition=is_sns_v1_provider(), reason="Not implemented in moto")
-    def test_data_protection_policy_crud(self, snapshot, aws_client):
+    def test_data_protection_policy_crud(self, snapshot, aws_client, region_name):
         topic_name = f"topic-{short_uid()}"
         topic_arn = aws_client.sns.create_topic(Name=topic_name)["TopicArn"]
 
@@ -623,7 +623,7 @@ def test_data_protection_policy_crud(self, snapshot, aws_client):
                     "DataDirection": "Inbound",
                     "Principal": ["*"],
                     "DataIdentifier": [
-                        "arn:aws:dataprotection:us-east-1::data-identifier/EmailAddress"
+                        f"arn:aws:dataprotection:{region_name}::data-identifier/EmailAddress"
                     ],
                     "Operation": {"Deny": {}},
                 }
diff --git a/tests/aws/services/sns/test_sns.snapshot.json b/tests/aws/services/sns/test_sns.snapshot.json
@@ -7030,7 +7030,7 @@
     }
   },
   "tests/aws/services/sns/test_sns.py::TestSNSTopicCrudV2::test_data_protection_policy_crud": {
-    "recorded-date": "17-12-2025, 13:06:58",
+    "recorded-date": "18-12-2025, 07:54:08",
     "recorded-content": {
       "get-topic-attributes-before-policy": {
         "Attributes": {
diff --git a/tests/aws/services/sns/test_sns.validation.json b/tests/aws/services/sns/test_sns.validation.json
@@ -1353,12 +1353,12 @@
     }
   },
   "tests/aws/services/sns/test_sns.py::TestSNSTopicCrudV2::test_data_protection_policy_crud": {
-    "last_validated_date": "2025-12-17T13:06:58+00:00",
+    "last_validated_date": "2025-12-18T07:54:08+00:00",
     "durations_in_seconds": {
-      "setup": 1.14,
-      "call": 2.36,
-      "teardown": 0.02,
-      "total": 3.52
+      "setup": 0.84,
+      "call": 1.82,
+      "teardown": 0.04,
+      "total": 2.7
     }
   },
   "tests/aws/services/sns/test_sns.py::TestSNSTopicCrudV2::test_delete_non_existent_topic": {

Original file line number	Diff line number	Diff line change
`@@ -7030,7 +7030,7 @@`
`7030`	`7030`	`}`
`7031`	`7031`	`},`
`7032`	`7032`	`"tests/aws/services/sns/test_sns.py::TestSNSTopicCrudV2::test_data_protection_policy_crud": {`
`7033`		`- "recorded-date": "17-12-2025, 13:06:58",`
	`7033`	`+ "recorded-date": "18-12-2025, 07:54:08",`
`7034`	`7034`	`"recorded-content": {`
`7035`	`7035`	`"get-topic-attributes-before-policy": {`
`7036`	`7036`	`"Attributes": {`