raise exception for undefined dependency in CFn template (#9521)

pinzon · web-flow · commit b3035104262b · 2023-11-02T10:39:21.000+01:00
diff --git a/localstack/services/cloudformation/engine/template_deployer.py b/localstack/services/cloudformation/engine/template_deployer.py
@@ -964,6 +964,10 @@ def get_unsatisfied_dependencies_for_resources(
     ):
         result = {}
         for resource_id, resource in resources.items():
+            if not resource:
+                raise Exception(
+                    f"Resource '{resource_id}' not found in stack {self.stack.stack_name}"
+                )
             if not self.is_deployed(resource):
                 LOG.debug(
                     "Dependency for resource %s not yet deployed: %s %s",
diff --git a/tests/aws/services/cloudformation/api/test_reference_resolving.py b/tests/aws/services/cloudformation/api/test_reference_resolving.py
@@ -83,3 +83,21 @@ def test_sub_resolving(deploy_cfn_template, aws_client, snapshot):
     # Verify resource was created
     topic_arns = [t["TopicArn"] for t in aws_client.sns.list_topics()["Topics"]]
     assert topic_arn in topic_arns
+
+
+@markers.aws.only_localstack
+def test_unexisting_resource_dependency(deploy_cfn_template, aws_client):
+    stack_name = f"s-{short_uid()}"
+
+    with pytest.raises(Exception):
+        deploy_cfn_template(
+            template_path=os.path.join(
+                os.path.dirname(__file__),
+                "../../../templates/cfn_unexisting_resource_dependency.yml",
+            ),
+            stack_name=stack_name,
+        )
+
+    description = aws_client.cloudformation.describe_stacks(StackName=stack_name)["Stacks"][0]
+    assert description["StackStatus"] == "CREATE_FAILED"
+    assert "Resource 'UnexistingResource' not found in stack" in description["StackStatusReason"]
diff --git a/tests/aws/templates/cfn_unexisting_resource_dependency.yml b/tests/aws/templates/cfn_unexisting_resource_dependency.yml
@@ -0,0 +1,7 @@
+Resources:
+  Parameter:
+    Type: AWS::SSM::Parameter::Value<String>
+    Properties:
+      Value: test
+      Type: String
+    DependsOn: UnexistingResource
