Add second example

simonrw · simonrw · commit a31ed234e7e1 · 2025-10-08T13:13:41.000+01:00
diff --git a/tests/aws/services/cloudformation/test_change_set_fn_get_attr.py b/tests/aws/services/cloudformation/test_change_set_fn_get_attr.py
@@ -313,12 +313,13 @@ def test_immutable_property_update_causes_resource_replacement(
         capture_update_process(snapshot, template_1, template_2)
 
     @markers.aws.validated
-    def test_invalid_structure(self, snapshot, deploy_cfn_template, aws_client):
+    @pytest.mark.parametrize("template_name", ["getatt_validation.yml", "getatt_validation2.yml"])
+    def test_invalid_structure(self, snapshot, deploy_cfn_template, aws_client, template_name):
         cs_name = f"cs-{short_uid()}"
         stack_name = f"stack-{short_uid()}"
 
         with open(
-            os.path.join(os.path.dirname(__file__), "../../templates/select_issue.yml")
+            os.path.join(os.path.dirname(__file__), f"../../templates/{template_name}")
         ) as infile:
             template_body = infile.read()
 
diff --git a/tests/aws/services/cloudformation/test_change_set_fn_get_attr.snapshot.json b/tests/aws/services/cloudformation/test_change_set_fn_get_attr.snapshot.json
@@ -3017,8 +3017,24 @@
       }
     }
   },
-  "tests/aws/services/cloudformation/test_change_set_fn_get_attr.py::TestChangeSetFnGetAttr::test_invalid_structure": {
-    "recorded-date": "08-10-2025, 12:01:24",
+  "tests/aws/services/cloudformation/test_change_set_fn_get_attr.py::TestChangeSetFnGetAttr::test_invalid_structure[getatt_validation.yml]": {
+    "recorded-date": "08-10-2025, 12:13:08",
+    "recorded-content": {
+      "error": {
+        "Error": {
+          "Code": "ValidationError",
+          "Message": "Template error: every Fn::GetAtt object requires two non-empty parameters, the resource name and the resource attribute",
+          "Type": "Sender"
+        },
+        "ResponseMetadata": {
+          "HTTPHeaders": {},
+          "HTTPStatusCode": 400
+        }
+      }
+    }
+  },
+  "tests/aws/services/cloudformation/test_change_set_fn_get_attr.py::TestChangeSetFnGetAttr::test_invalid_structure[getatt_validation2.yml]": {
+    "recorded-date": "08-10-2025, 12:13:08",
     "recorded-content": {
       "error": {
         "Error": {
diff --git a/tests/aws/services/cloudformation/test_change_set_fn_get_attr.validation.json b/tests/aws/services/cloudformation/test_change_set_fn_get_attr.validation.json
@@ -11,13 +11,22 @@
   "tests/aws/services/cloudformation/test_change_set_fn_get_attr.py::TestChangeSetFnGetAttr::test_immutable_property_update_causes_resource_replacement": {
     "last_validated_date": "2025-04-08T12:17:00+00:00"
   },
-  "tests/aws/services/cloudformation/test_change_set_fn_get_attr.py::TestChangeSetFnGetAttr::test_invalid_structure": {
-    "last_validated_date": "2025-10-08T12:01:24+00:00",
+  "tests/aws/services/cloudformation/test_change_set_fn_get_attr.py::TestChangeSetFnGetAttr::test_invalid_structure[getatt_validation.yml]": {
+    "last_validated_date": "2025-10-08T12:13:08+00:00",
     "durations_in_seconds": {
-      "setup": 0.9,
-      "call": 0.32,
+      "setup": 0.96,
+      "call": 0.31,
       "teardown": 0.0,
-      "total": 1.22
+      "total": 1.27
+    }
+  },
+  "tests/aws/services/cloudformation/test_change_set_fn_get_attr.py::TestChangeSetFnGetAttr::test_invalid_structure[getatt_validation2.yml]": {
+    "last_validated_date": "2025-10-08T12:13:08+00:00",
+    "durations_in_seconds": {
+      "setup": 0.0,
+      "call": 0.15,
+      "teardown": 0.0,
+      "total": 0.15
     }
   },
   "tests/aws/services/cloudformation/test_change_set_fn_get_attr.py::TestChangeSetFnGetAttr::test_resource_addition": {
diff --git a/tests/aws/templates/getatt_validation.yml b/tests/aws/templates/getatt_validation.yml
diff --git a/tests/aws/templates/getatt_validation2.yml b/tests/aws/templates/getatt_validation2.yml
@@ -0,0 +1,18 @@
+Parameters:
+  MyParameterValue:
+    Type: String
+
+Resources:
+  MyParameter1:
+    Type: AWS::SSM::Parameter
+    Properties:
+      Type: String
+      Value: foo
+
+  MyParameter2:
+    Type: AWS::SSM::Parameter
+    Properties:
+      Type: String
+      Value:
+        Fn::GetAtt:
+          - MyParameter1
