work in more review suggestions

baermat · baermat · commit 847e34dec217 · 2025-10-15T14:19:02.000+02:00
diff --git a/localstack-core/localstack/services/sns/v2/provider.py b/localstack-core/localstack/services/sns/v2/provider.py
@@ -639,12 +639,12 @@ def _validate_sms_attributes(attributes: dict) -> None:
     for k, v in attributes.items():
         if k not in SMS_ATTRIBUTE_NAMES:
             raise InvalidParameterException(f"{k} is not a valid attribute")
-        default_send_id = attributes.get("DefaultSendID")
-        if default_send_id and not re.match(SMS_DEFAULT_SENDER_REGEX, default_send_id):
-            raise InvalidParameterException(f"{k} is not a valid attribute")
-        sms_type = attributes.get("DefaultSMSType")
-        if sms_type and sms_type not in SMS_TYPES:
-            raise InvalidParameterException("DefaultSMSType is invalid")
+    default_send_id = attributes.get("DefaultSendID")
+    if default_send_id and not re.match(SMS_DEFAULT_SENDER_REGEX, default_send_id):
+        raise InvalidParameterException("DefaultSendID is not a valid attribute")
+    sms_type = attributes.get("DefaultSMSType")
+    if sms_type and sms_type not in SMS_TYPES:
+        raise InvalidParameterException("DefaultSMSType is invalid")
 
 
 def _set_sms_attribute_default(store: SnsStore) -> None:
diff --git a/tests/aws/services/sns/test_sns.validation.json b/tests/aws/services/sns/test_sns.validation.json
@@ -75,39 +75,39 @@
     }
   },
   "tests/aws/services/sns/test_sns.py::TestSNSSMS::test_set_invalid_sms_attributes[InvalidAttributeName]": {
-    "last_validated_date": "2025-10-13T10:43:41+00:00",
+    "last_validated_date": "2025-10-15T12:14:04+00:00",
     "durations_in_seconds": {
-      "setup": 0.95,
-      "call": 0.71,
-      "teardown": 0.06,
-      "total": 1.72
+      "setup": 1.45,
+      "call": 1.32,
+      "teardown": 0.0,
+      "total": 2.77
     }
   },
   "tests/aws/services/sns/test_sns.py::TestSNSSMS::test_set_invalid_sms_attributes[InvalidSMSType]": {
-    "last_validated_date": "2025-10-13T10:43:57+00:00",
+    "last_validated_date": "2025-10-15T12:14:12+00:00",
     "durations_in_seconds": {
       "setup": 0.0,
-      "call": 4.86,
-      "teardown": 0.01,
-      "total": 4.87
+      "call": 2.24,
+      "teardown": 0.0,
+      "total": 2.24
     }
   },
   "tests/aws/services/sns/test_sns.py::TestSNSSMS::test_set_invalid_sms_attributes[NoLetterID]": {
-    "last_validated_date": "2025-10-13T10:43:52+00:00",
+    "last_validated_date": "2025-10-15T12:14:09+00:00",
     "durations_in_seconds": {
-      "setup": 0.0,
-      "call": 6.68,
-      "teardown": 0.01,
-      "total": 6.69
+      "setup": 0.01,
+      "call": 3.39,
+      "teardown": 0.0,
+      "total": 3.4
     }
   },
   "tests/aws/services/sns/test_sns.py::TestSNSSMS::test_set_invalid_sms_attributes[TooLongID]": {
-    "last_validated_date": "2025-10-13T10:43:45+00:00",
+    "last_validated_date": "2025-10-15T12:14:06+00:00",
     "durations_in_seconds": {
-      "setup": 0.0,
-      "call": 3.58,
-      "teardown": 0.01,
-      "total": 3.59
+      "setup": 0.1,
+      "call": 1.78,
+      "teardown": 0.0,
+      "total": 1.88
     }
   },
   "tests/aws/services/sns/test_sns.py::TestSNSSMS::test_set_invalid_sms_attributes[attribute_key_value0]": {
