Remove extra try/except

simonrw · simonrw · commit 72f71f282d31 · 2025-09-25T10:55:16.000+01:00
diff --git a/localstack-core/localstack/services/cloudformation/engine/v2/change_set_model_preproc.py b/localstack-core/localstack/services/cloudformation/engine/v2/change_set_model_preproc.py
@@ -435,19 +435,13 @@ def _perform_dynamic_replacements(self, value: _T) -> _T:
             return value
 
         if dynamic_ref := extract_dynamic_reference(value):
-            try:
-                new_value = perform_dynamic_reference_lookup(
-                    reference=dynamic_ref,
-                    account_id=self._change_set.account_id,
-                    region_name=self._change_set.region_name,
-                )
-                if new_value:
-                    return REGEX_DYNAMIC_REF.sub(new_value, value)
-            except Exception:
-                # we cannot look this reference up right now, however that might be because we
-                # are visiting the arguments to an intrinsic function that will eventually create
-                # a full reference.
-                pass
+            new_value = perform_dynamic_reference_lookup(
+                reference=dynamic_ref,
+                account_id=self._change_set.account_id,
+                region_name=self._change_set.region_name,
+            )
+            if new_value:
+                return REGEX_DYNAMIC_REF.sub(new_value, value)
 
         return value
 
