Rework to avoid placeholder type

viren-nadkarni · viren-nadkarni · commit 6236f11f2cd5 · 2025-11-28T15:00:56.000+05:30
diff --git a/localstack-core/localstack/aws/handlers/logging.py b/localstack-core/localstack/aws/handlers/logging.py
@@ -1,7 +1,6 @@
 """Handlers for logging."""
 
 import logging
-import types
 from functools import cached_property
 
 from localstack.aws.api import RequestContext, ServiceException
@@ -22,17 +21,17 @@ class ExceptionLogger(ExceptionHandler):
     def __init__(self, logger=None):
         self.logger = logger or LOG
 
-        self._moto_service_exception = types.EllipsisType
-        self._moto_rest_error = types.EllipsisType
-
         try:
             import moto.core.exceptions
 
-            self._moto_service_exception = moto.core.exceptions.ServiceException
-            self._moto_rest_error = moto.core.exceptions.RESTError
+            self._skip_exceptions(
+                ServiceException,
+                moto.core.exceptions.ServiceException,
+                moto.core.exceptions.RESTError,
+            )
         except (ModuleNotFoundError, AttributeError):
             # Moto may not be available in stripped-down versions of LocalStack, like LocalStack S3 image.
-            pass
+            self._skip_exceptions = (ServiceException,)
 
     def __call__(
         self,
@@ -41,13 +40,12 @@ def __call__(
         context: RequestContext,
         response: Response,
     ):
-        if isinstance(
-            exception, (ServiceException, self._moto_service_exception, self._moto_rest_error)
-        ):
+        if isinstance(exception, self._skip_exceptions):
             # We do not want to log an error/stacktrace if the handler is working as expected, but chooses to throw
             # a service exception. It may also throw a Moto ServiceException, which should not be logged either
             # because ServiceExceptionHandler understands it.
             return
+
         if self.logger.isEnabledFor(level=logging.DEBUG):
             self.logger.exception("exception during call chain", exc_info=exception)
         else:
