fix use of describe unit for creation value

MEPalma · MEPalma · commit 4333eacedd5c · 2025-03-10T12:00:11.000+01:00
diff --git a/localstack-core/localstack/services/cloudformation/engine/v2/change_set_model_describer.py b/localstack-core/localstack/services/cloudformation/engine/v2/change_set_model_describer.py
@@ -52,7 +52,7 @@ def visit_terminal_value_modified(
     def visit_terminal_value_created(
         self, terminal_value_created: TerminalValueCreated
     ) -> DescribeUnit:
-        return DescribeUnit(before_context=terminal_value_created.value)
+        return DescribeUnit(after_context=terminal_value_created.value)
 
     def visit_terminal_value_removed(
         self, terminal_value_removed: TerminalValueRemoved
@@ -74,7 +74,7 @@ def visit_node_object(self, node_object: NodeObject) -> DescribeUnit:
                     before_context[name] = describe_unit.before_context
                     after_context[name] = describe_unit.after_context
                 case ChangeType.CREATED:
-                    after_context[name] = describe_unit.before_context
+                    after_context[name] = describe_unit.after_context
                 case ChangeType.REMOVED:
                     before_context[name] = describe_unit.before_context
         return DescribeUnit(before_context=before_context, after_context=after_context)
@@ -89,7 +89,7 @@ def visit_node_array(self, node_array: NodeArray) -> DescribeUnit:
                     before_context.append(describe_unit.before_context)
                     after_context.append(describe_unit.after_context)
                 case ChangeType.CREATED:
-                    after_context.append(describe_unit.before_context)
+                    after_context.append(describe_unit.after_context)
                 case ChangeType.REMOVED:
                     before_context.append(describe_unit.before_context)
                 case ChangeType.UNCHANGED:
@@ -110,7 +110,7 @@ def visit_node_properties(self, node_properties: NodeProperties) -> DescribeUnit
                     before_context[property_name] = describe_unit.before_context
                     after_context[property_name] = describe_unit.after_context
                 case ChangeType.CREATED:
-                    after_context[property_name] = describe_unit.before_context
+                    after_context[property_name] = describe_unit.after_context
                 case ChangeType.REMOVED:
                     before_context[property_name] = describe_unit.before_context
         # TODO: this object can probably be well-typed instead of a free dict(?)
