Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Commit 3d25169

Browse files
aidehnbentsku
andauthored
Fix: Update Dev Run to mount plux.ini instead of entry_points.txt for localstack dependencies (#13708)
Co-authored-by: Ben Simon Hartung <[email protected]>
1 parent 55611d1 commit 3d25169

File tree

1 file changed

+19
-18
lines changed

1 file changed

+19
-18
lines changed

localstack-core/localstack/dev/run/configurators.py

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,17 @@ class EntryPointMountConfigurator:
192192
For example, when starting the pro container, the entrypoints of localstack-pro on the host would be in
193193
``~/workspace/localstack-pro/localstack-pro-core/localstack_ext.egg-info/entry_points.txt``
194194
which needs to be mounted into the distribution info of the installed dependency within the container:
195-
``/opt/code/localstack/.venv/.../site-packages/localstack_ext-2.1.0.dev0.dist-info/entry_points.txt``.
195+
Mounts ``plux.ini`` files of localstack and localstack-pro into the venv in the container.
196+
For other dependencies, we mount the ``entry_points.txt`` build artifacts.
197+
198+
For example, when starting the pro container, the entrypoints of localstack-pro on the host would be in
199+
``~/workspace/localstack-pro/localstack-pro-core/plux.ini`` which needs to be mounted into the distribution info of the installed dependency within the container:
200+
``/opt/code/localstack/.venv/.../site-packages/localstack_ext-4.13.0.dev0.dist-info/entry_points.txt``.
201+
202+
For a dependency using plugins, the entrypoints would be in the build artifact at
203+
``~/workspace/<dependency>/<package-name>.egg-info/entry_points.txt``
204+
which also needs to be mounted into the distribution info of the installed dependency within the container:
205+
``/opt/code/localstack/.venv/.../site-packages/<package-name>.dist-info/entry_points.txt``.
196206
"""
197207

198208
entry_point_glob = (
@@ -236,12 +246,7 @@ def __call__(self, cfg: ContainerConfiguration):
236246
dep, ver = dep_path.split("-")
237247

238248
if dep == "localstack_core":
239-
host_path = (
240-
self.host_paths.localstack_project_dir
241-
/ "localstack-core"
242-
/ "localstack_core.egg-info"
243-
/ "entry_points.txt"
244-
)
249+
host_path = self.host_paths.localstack_project_dir / "plux.ini"
245250
if host_path.is_file():
246251
cfg.volumes.add(
247252
BindMount(
@@ -250,13 +255,9 @@ def __call__(self, cfg: ContainerConfiguration):
250255
read_only=True,
251256
)
252257
)
253-
continue
254258
elif dep == "localstack_ext":
255259
host_path = (
256-
self.host_paths.localstack_pro_project_dir
257-
/ "localstack-pro-core"
258-
/ "localstack_ext.egg-info"
259-
/ "entry_points.txt"
260+
self.host_paths.localstack_pro_project_dir / "localstack-pro-core" / "plux.ini"
260261
)
261262
if host_path.is_file():
262263
cfg.volumes.add(
@@ -266,12 +267,12 @@ def __call__(self, cfg: ContainerConfiguration):
266267
read_only=True,
267268
)
268269
)
269-
continue
270-
for host_path in self.host_paths.workspace_dir.glob(
271-
f"*/{dep}.egg-info/entry_points.txt"
272-
):
273-
cfg.volumes.add(BindMount(str(host_path), str(container_path), read_only=True))
274-
break
270+
else:
271+
for host_path in self.host_paths.workspace_dir.glob(
272+
f"*/{dep}.egg-info/entry_points.txt"
273+
):
274+
cfg.volumes.add(BindMount(str(host_path), str(container_path), read_only=True))
275+
break
275276

276277

277278
class DependencyMountConfigurator:

0 commit comments

Comments
 (0)