Explicitly specify Java 11 as DDBLocal dependency

viren-nadkarni · viren-nadkarni · commit 316b49ff7a4c · 2024-07-31T15:28:12.000+05:30
diff --git a/localstack-core/localstack/services/dynamodb/packages.py b/localstack-core/localstack/services/dynamodb/packages.py
@@ -4,6 +4,7 @@
 from localstack import config
 from localstack.constants import ARTIFACTS_REPO, MAVEN_REPO_URL
 from localstack.packages import InstallTarget, Package, PackageInstaller
+from localstack.packages.java import java_package
 from localstack.utils.archives import (
     download_and_extract_with_retry,
     update_jar_manifest,
@@ -41,6 +42,9 @@ class DynamoDBLocalPackageInstaller(PackageInstaller):
     def __init__(self):
         super().__init__("dynamodb-local", "latest")
 
+    def _prepare_installation(self, target: InstallTarget) -> None:
+        java_package.install(version="11", target=target)
+
     def _install(self, target: InstallTarget):
         # download and extract archive
         tmp_archive = os.path.join(config.dirs.cache, "localstack.ddb.zip")
diff --git a/localstack-core/localstack/services/dynamodb/server.py b/localstack-core/localstack/services/dynamodb/server.py
@@ -7,6 +7,7 @@
 from localstack.aws.forwarder import AwsRequestProxy
 from localstack.config import is_env_true
 from localstack.constants import DEFAULT_AWS_ACCOUNT_ID
+from localstack.packages.java import java_package
 from localstack.services.dynamodb.packages import dynamodblocal_package
 from localstack.utils.common import TMP_THREADS, ShellCommandThread, get_free_tcp_port, mkdir
 from localstack.utils.functions import run_safe
@@ -160,7 +161,10 @@ def do_start_thread(self) -> FuncThread:
             log_listener=_log_listener,
             auto_restart=True,
             name="dynamodb-local",
-            env_vars={"DDB_LOCAL_TELEMETRY": "0"},
+            env_vars={
+                "JAVA_HOME": java_package.get_installer("11").get_java_home(),
+                "DDB_LOCAL_TELEMETRY": "0",
+            },
         )
         TMP_THREADS.append(t)
         t.start()
