SES: Fix regression caused by Moto changes

viren-nadkarni · viren-nadkarni · commit 314a9617b398 · 2025-09-17T18:09:50.000+05:30
See getmoto/moto#9249
diff --git a/localstack-core/localstack/services/ses/provider.py b/localstack-core/localstack/services/ses/provider.py
@@ -183,6 +183,8 @@ class SesProvider(SesApi, ServiceLifecycleHook):
     #
 
     def on_after_init(self):
+        self._apply_patches()
+
         # Allow sent emails to be retrieved from the SES emails endpoint
         register_ses_api_resource()
 
@@ -198,6 +200,12 @@ def get_source_from_raw(self, raw_data: str) -> str | None:
                 return entity.replace("From:", "").strip()
         return None
 
+    def _apply_patches(self) -> None:
+        # Suppress Moto's validation of receipt rule actions. These validations use Moto's implementation of S3, Lambda
+        # and SQS, which fail because these services have been internalised in LocalStack.
+        # Besides, AWS does not run the same validations as evidenced by our AWS-validated tests.
+        SESBackend._validate_receipt_rule_actions = lambda *_: None
+
     #
     # Implementations for SES operations
     #
@@ -519,8 +527,10 @@ def clone_receipt_rule_set(
         backend.create_receipt_rule_set(rule_set_name)
         original_rule_set = backend.describe_receipt_rule_set(original_rule_set_name)
 
+        after = None
         for rule in original_rule_set.rules:
-            backend.create_receipt_rule(rule_set_name, rule)
+            backend.create_receipt_rule(rule_set_name, rule, after)
+            after = rule["Name"]
 
         return CloneReceiptRuleSetResponse()
 
diff --git a/tests/aws/services/ses/test_ses.snapshot.json b/tests/aws/services/ses/test_ses.snapshot.json
@@ -806,7 +806,7 @@
     }
   },
   "tests/aws/services/ses/test_ses.py::TestSES::test_clone_receipt_rule_set": {
-    "recorded-date": "25-08-2023, 23:05:14",
+    "recorded-date": "17-09-2025, 11:56:18",
     "recorded-content": {
       "create-receipt-rule-set": {
         "ResponseMetadata": {
diff --git a/tests/aws/services/ses/test_ses.validation.json b/tests/aws/services/ses/test_ses.validation.json
@@ -3,7 +3,13 @@
     "last_validated_date": "2023-08-25T22:04:12+00:00"
   },
   "tests/aws/services/ses/test_ses.py::TestSES::test_clone_receipt_rule_set": {
-    "last_validated_date": "2023-08-25T21:05:14+00:00"
+    "last_validated_date": "2025-09-17T11:56:18+00:00",
+    "durations_in_seconds": {
+      "setup": 1.83,
+      "call": 2.56,
+      "teardown": 2.05,
+      "total": 6.44
+    }
   },
   "tests/aws/services/ses/test_ses.py::TestSES::test_creating_event_destination_without_configuration_set": {
     "last_validated_date": "2023-08-25T22:04:35+00:00"

Original file line number	Diff line number	Diff line change
`@@ -806,7 +806,7 @@`
`806`	`806`	`}`
`807`	`807`	`},`
`808`	`808`	`"tests/aws/services/ses/test_ses.py::TestSES::test_clone_receipt_rule_set": {`
`809`		`- "recorded-date": "25-08-2023, 23:05:14",`
	`809`	`+ "recorded-date": "17-09-2025, 11:56:18",`
`810`	`810`	`"recorded-content": {`
`811`	`811`	`"create-receipt-rule-set": {`
`812`	`812`	`"ResponseMetadata": {`