self-review cleanup

simonrw · simonrw · commit 0c6bb6d84740 · 2025-08-08T23:08:11.000+01:00
diff --git a/localstack-core/localstack/services/cloudformation/engine/v2/change_set_model_executor.py b/localstack-core/localstack/services/cloudformation/engine/v2/change_set_model_executor.py
@@ -90,8 +90,6 @@ def execute(self) -> ChangeSetModelExecutorResult:
         return ChangeSetModelExecutorResult(
             resources=self.resources,
             outputs=self.outputs,
-            # TODO: extract from outputs
-            # exports=self.exports,
         )
 
     def _defer_action(self, action: DeferredAction):
diff --git a/localstack-core/localstack/services/cloudformation/v2/provider.py b/localstack-core/localstack/services/cloudformation/v2/provider.py
@@ -479,7 +479,6 @@ def create_change_set(
 
             change_set.set_change_set_status(ChangeSetStatus.CREATE_COMPLETE)
 
-        # stack.change_set_id = change_set.change_set_id
         stack.change_set_ids.append(change_set.change_set_id)
         state.change_sets[change_set.change_set_id] = change_set
 
diff --git a/tests/aws/services/cloudformation/api/test_changesets.py b/tests/aws/services/cloudformation/api/test_changesets.py
@@ -759,8 +759,8 @@ def assert_bucket_gone():
 
 @markers.snapshot.skip_snapshot_verify(
     paths=[
-        "$..IncludeNestedStacks",
         "$..NotificationARNs",
+        "$..IncludeNestedStacks",
         "$..Parameters",
     ]
     + skipped_v2_items(

Original file line number	Diff line number	Diff line change
`@@ -90,8 +90,6 @@ def execute(self) -> ChangeSetModelExecutorResult:`
`90`	`90`	`return ChangeSetModelExecutorResult(`
`91`	`91`	`resources=self.resources,`
`92`	`92`	`outputs=self.outputs,`
`93`		`- # TODO: extract from outputs`
`94`		`- # exports=self.exports,`
`95`	`93`	`)`
`96`	`94`
`97`	`95`	`def _defer_action(self, action: DeferredAction):`
Original file line number	Diff line number	Diff line change
`@@ -759,8 +759,8 @@ def assert_bucket_gone():`
`759`	`759`
`760`	`760`	`@markers.snapshot.skip_snapshot_verify(`
`761`	`761`	`paths=[`
`762`		`- "$..IncludeNestedStacks",`
`763`	`762`	`"$..NotificationARNs",`
	`763`	`+ "$..IncludeNestedStacks",`
`764`	`764`	`"$..Parameters",`
`765`	`765`	`]`
`766`	`766`	`+ skipped_v2_items(`