Add a to_change_action for getting the change action

simonrw · simonrw · commit 07f06d087ae7 · 2025-07-24T15:19:47.000+01:00
diff --git a/localstack-core/localstack/services/cloudformation/engine/v2/change_set_model.py b/localstack-core/localstack/services/cloudformation/engine/v2/change_set_model.py
@@ -7,6 +7,7 @@
 
 from typing_extensions import TypeVar
 
+from localstack.aws.api.cloudformation import ChangeAction
 from localstack.utils.strings import camel_to_snake_case
 
 T = TypeVar("T")
@@ -109,6 +110,14 @@ class ChangeType(enum.Enum):
     def __str__(self):
         return self.value
 
+    def to_change_action(self) -> ChangeAction:
+        # Convert this change type into the change action used throughout the CFn API
+        return {
+            ChangeType.CREATED: ChangeAction.Add,
+            ChangeType.MODIFIED: ChangeAction.Modify,
+            ChangeType.REMOVED: ChangeAction.Remove,
+        }.get(self, ChangeAction.Add)
+
 
 class ChangeSetEntity(abc.ABC):
     scope: Final[Scope]
diff --git a/localstack-core/localstack/services/cloudformation/engine/v2/change_set_model_executor.py b/localstack-core/localstack/services/cloudformation/engine/v2/change_set_model_executor.py
@@ -180,9 +180,8 @@ def visit_node_resource(
         try:
             delta = super().visit_node_resource(node_resource=node_resource)
         except Exception as e:
-            # TODO: change action may not match the change type
             self._process_event(
-                ChangeAction.Modify,
+                node_resource.change_type.to_change_action(),
                 node_resource.name,
                 OperationStatus.FAILED,
                 reason=str(e),
