Skip to content

Comments

🐛 fix: ensure request body properties are defined#43

Merged
arvinxx merged 1 commit intolobehub:masterfrom
luquitared:master
Jun 30, 2024
Merged

🐛 fix: ensure request body properties are defined#43
arvinxx merged 1 commit intolobehub:masterfrom
luquitared:master

Conversation

@luquitared
Copy link
Contributor

@luquitared luquitared commented Jun 30, 2024 •
edited by arvinxx
Loading

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

🔀 变更说明 | Description of Change

Sometimes when parsing more complex openapi schemas, this crash can happen:

Error processing request: TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at OpenAPIConvertor.convertOpenAPIToPluginSchema (/Users/lucasnegritto/projects/dynama-builder/tools-api/node_modules/@lobehub/chat-plugin-sdk/lib/openapi/index.js:55:45)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async convertManifest (/Users/lucasnegritto/projects/dynama-builder/tools-api/index.js:43:26)
    at async /Users/lucasnegritto/projects/dynama-builder/tools-api/index.js:74:54

By ensuring the request body properties are defined, we prevent trying to convert an undefined or null object to keys, avoiding the TypeError.

@lobehubbot
Copy link
Member

lobehubbot commented Jun 30, 2024

👍 @luquitared


Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@arvinxx arvinxx changed the title ensure request body properties are defined 🐛 fix: ensure request body properties are defined Jun 30, 2024
@arvinxx arvinxx merged commit 933b53c into lobehub:master Jun 30, 2024
@lobehubbot
Copy link
Member

lobehubbot commented Jun 30, 2024

❤️ Great PR @luquitared ❤️


The growth of project is inseparable from user feedback and contribution, thanks for your contribution!
项目的成长离不开用户反馈和贡献，感谢您的贡献!

lobehubbot pushed a commit that referenced this pull request Jun 30, 2024
@semantic-release-bot
🔖 chore(release): v1.32.4 [skip ci]
0f53dda 
### [Version&nbsp;1.32.4](v1.32.3...v1.32.4)
<sup>Released on **2024-06-30**</sup>

#### 🐛 Bug Fixes

- **misc**: Ensure request body properties are defined.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Ensure request body properties are defined, closes [#43](#43) ([933b53c](933b53c))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

lobehubbot commented Jun 30, 2024

🎉 This PR is included in version 1.32.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luquitared @lobehubbot @arvinxx