Skip to content

Conversation

@8go
Copy link
Contributor

@8go 8go commented Apr 21, 2020

  • changed the order a bit.
  • since "invoice" is introduced it should be explained right away
  • addition, explaining differences in concepts to Bitcoin

- changed the order a bit.
- since "invoice" is introduced it should be explained right away what it is
- addition, explaining differences in concepts to Bitcoin
Copy link
Contributor

@renepickhardt renepickhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two ideas for further improvements. other than that LGTM

@8go
Copy link
Contributor Author

8go commented Apr 23, 2020

All done.
See Commit 2 and 3 in 97b20db and 9a737b1

Ready for review and pull. Kind regards.

@8go 8go requested a review from renepickhardt April 23, 2020 17:04
@8go 8go requested a review from Roasbeef May 6, 2020 14:15
Copy link
Contributor

@renepickhardt renepickhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@renepickhardt renepickhardt merged commit ba64c16 into lnbook:develop Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants