gh-249 Remove MDB_UNSIGNEDKEY, let CursorIterable call mdb_cmp #250

at055612 · 2025-03-06T16:12:27Z

Fixes #249

There are now essentially three ways of configuring comparators when creating a Dbi.

null comparator
LMDB will use its own comparator & CursorIterable will call down to mdb_cmp for comparisons between the current cursor key and the range start/stop key.

provided comparator
LMDB will use its own comparator & CursorIterable will use the provided comparator for comparisons between the current cursor key and the range start/stop key.

provided comparator with nativeCb==true
LMDB will call back to java for all comparator duties. CursorIterable will use the same provided comparator for comparisons between the current cursor key and the range start/stop key.

The methods getSignedComparator() and getUnsignedComparator() have been made public so users of this library can access them.

There are now essentially three ways of configuring comparators when creating a Dbi. **null comparator** LMDB will use its own comparator & CursorIterable will call down to mdb_cmp for comparisons between the current cursor key and the range start/stop key. **provided comparator** LMDB will use its own comparator & CursorIterable will use the provided comparator for comparisons between the current cursor key and the range start/stop key. **provided comparator with nativeCb==true** LMDB will call back to java for all comparator duties. CursorIterable will use the same provided comparator for comparisons between the current cursor key and the range start/stop key. The methods `getSignedComparator()` and `getUnsignedComparator()` have been made public so users of this library can access them.

codecov · 2025-03-06T16:15:59Z

Codecov Report

❌ Patch coverage is 73.06452% with 167 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.06%. Comparing base (65df2ee) to head (dea7975).

Files with missing lines	Patch %	Lines
src/main/java/org/lmdbjava/AbstractFlagSet.java	72.61%	13 Missing and 10 partials ⚠️
src/main/java/org/lmdbjava/Env.java	63.79%	17 Missing and 4 partials ⚠️
src/main/java/org/lmdbjava/DbiBuilder.java	77.01%	13 Missing and 7 partials ⚠️
src/main/java/org/lmdbjava/Cursor.java	57.57%	8 Missing and 6 partials ⚠️
src/main/java/org/lmdbjava/FlagSet.java	63.33%	6 Missing and 5 partials ⚠️
src/main/java/org/lmdbjava/ByteBufProxy.java	62.96%	6 Missing and 4 partials ⚠️
src/main/java/org/lmdbjava/Dbi.java	72.22%	8 Missing and 2 partials ⚠️
src/main/java/org/lmdbjava/CopyFlagSet.java	50.00%	9 Missing ⚠️
src/main/java/org/lmdbjava/TxnFlagSet.java	62.50%	6 Missing ⚠️
src/main/java/org/lmdbjava/Key.java	73.68%	4 Missing and 1 partial ⚠️
... and 13 more

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
- Coverage     89.06%   85.06%   -4.01%     
- Complexity      413      507      +94     
============================================
  Files            32       41       +9     
  Lines          1482     1962     +480     
  Branches        125      180      +55     
============================================
+ Hits           1320     1669     +349     
- Misses           92      177      +85     
- Partials         70      116      +46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

src/main/java/org/lmdbjava/KeyRangeType.java

src/test/java/org/lmdbjava/CursorIterablePerfTest.java

+            cnt++;
+          }
+        }
+        final Duration duration = Duration.between(start, Instant.now());


src/test/java/org/lmdbjava/CursorIterableTest.java

src/test/java/org/lmdbjava/CursorIterableIntegerKeyTest.java

src/main/java/org/lmdbjava/DbiBuilder.java

src/test/java/org/lmdbjava/CursorIterableIntegerKeyTest.java

+          bb1.get(array1);
+          bb2.get(array2);
+          bb1.reset();
+          bb2.reset();


src/test/java/org/lmdbjava/CursorIterablePerfTest.java

src/test/java/org/lmdbjava/CursorIterableTest.java

src/test/java/org/lmdbjava/CursorIterableIntegerKeyTest.java

Refactor DbiBuilder and Dbi ctor to use DbiFlagSet.

Replace Env#copy(File, CopyFlags...) with copy(File, CopyFlagSet). As there is only one flag this should not be a breaking change. Deprecate Env#txn(Txn, TxnFlags...) as there is now Env#txn(Txn) Env#txn(Txn, TxnFlags) Env#txn(Txn, TxnFlagSet)

src/main/java/org/lmdbjava/AbstractFlagSet.java

src/main/java/org/lmdbjava/Env.java

src/main/java/org/lmdbjava/FlagSet.java

Also improve javadoc and refactor some tests to use DbiBuilder. Some tests are failing.

src/main/java/org/lmdbjava/BufferProxy.java

src/main/java/org/lmdbjava/DbiBuilder.java

+      if (txn != null) {
+        return open(txn, dbiBuilder);
+      } else {
+        try (final Txn<T> txn = getTxn(dbiBuilder)) {


src/main/java/org/lmdbjava/FlagSet.java

+  /**
+   * @return The {@link Iterator} (in no particular order) for the flags in this {@link FlagSet}.
+   */
+  default Iterator<T> iterator() {


src/test/java/org/lmdbjava/CursorIterablePerfTest.java

+        try (Txn<ByteBuffer> txn = env.txnWrite();
+            final Cursor<ByteBuffer> cursor = db.openCursor(txn)) {
+          while (cursor.next()) {
+            cursor.delete();


src/test/java/org/lmdbjava/ByteBufferProxyTest.java

+    final long[] values = random.longs(5_000_000).toArray();
+
+    Instant time = Instant.now();
+    int x = 0;


src/test/java/org/lmdbjava/CursorIterableIntegerDupTest.java

+          bb2.reset();
+          return guava.compare(array1, array2);
+        };
+    final Dbi<ByteBuffer> guavaDbi = env.openDbi(DB_1, comparator, MDB_CREATE);


src/test/java/org/lmdbjava/CursorIterableIntegerDupTest.java

+        create(bufferProxy)
+            .setMapSize(KIBIBYTES.toBytes(256))
+            .setMaxReaders(1)
+            .setMaxDbs(3)
+            .open(file.toFile(), POSIX_MODE, MDB_NOSUBDIR);


src/test/java/org/lmdbjava/CursorIterableIntegerKeyTest.java

+    try (Txn<ByteBuffer> txn = env.txnRead()) {
+      try (CursorIterable<ByteBuffer> iterable = db.iterate(txn)) {
+        for (KeyVal<ByteBuffer> keyVal : iterable) {
+          final String val = getString(keyVal.val());


src/test/java/org/lmdbjava/CursorIterableIntegerKeyTest.java

+      try (CursorIterable<ByteBuffer> iterable = db.iterate(txn)) {
+        for (KeyVal<ByteBuffer> keyVal : iterable) {
+          final String val = getString(keyVal.val());
+          final long key = getNativeLong(keyVal.key());


src/test/java/org/lmdbjava/CursorIterableIntegerKeyTest.java

+        for (KeyVal<ByteBuffer> keyVal : iterable) {
+          final String val = getString(keyVal.val());
+          final long key = getNativeLong(keyVal.key());
+          final int remaining = keyVal.key().remaining();


src/test/java/org/lmdbjava/CursorIterablePerfTest.java

+        create(bufferProxy)
+            .setMapSize(GIBIBYTES.toBytes(1))
+            .setMaxReaders(1)
+            .setMaxDbs(3)
+            .open(file.toFile(), POSIX_MODE, MDB_NOSUBDIR);


at055612 · 2025-11-05T17:08:16Z

Closing this as the changes have been moved to PR #276

at055612 added 2 commits March 6, 2025 17:27

lmdbjavagh-249 Remove non-J8 features, use indent size 2

46f8d08

lmdbjavagh-249 Fix indents

f92012e

github-advanced-security bot found potential problems Mar 6, 2025

View reviewed changes

at055612 added 3 commits March 6, 2025 19:02

lmdbjavagh-249 Tidy code and refactor RangeComparator impls

e1756d6

lmdbjavagh-249 Remove commented code

9509f6b

lmdbjavagh-249 Add CursorIterableIntegerKeyTest

67e2df1

github-advanced-security bot found potential problems Mar 7, 2025

View reviewed changes

src/test/java/org/lmdbjava/CursorIterableIntegerKeyTest.java Fixed Show fixed Hide fixed

src/test/java/org/lmdbjava/CursorIterableIntegerKeyTest.java Fixed Show fixed Hide fixed

benalexau mentioned this pull request Mar 8, 2025

The new MDB_UNSIGNEDKEY DbiFlag should probably be the default behaviour #249

Closed

lmdbjavagh-249 Remove MaskedFlag.isPropagatedToLmdb, add DbiBuilder WIP

620a89f

github-advanced-security bot found potential problems Jun 5, 2025

View reviewed changes

at055612 mentioned this pull request Oct 24, 2025

Java 25, the Foreign Function & Memory API and removal of Unsafe #259

Open

benalexau force-pushed the master branch 2 times, most recently from 5e03aec to e598e21 Compare October 25, 2025 04:27

Merge branch 'master' into mdb_cmp

75d87d0

github-advanced-security bot found potential problems Oct 26, 2025

View reviewed changes

src/test/java/org/lmdbjava/CursorIterableIntegerKeyTest.java Fixed Show fixed Hide fixed

src/test/java/org/lmdbjava/CursorIterableIntegerKeyTest.java Fixed Show fixed Hide fixed

at055612 added 5 commits October 26, 2025 21:49

Merge branch 'master' into mdb_cmp

47b4c4f

Add FlagSet, DbiFlagSet, PutFlagSet

bfbf223

Refactor DbiBuilder and Dbi ctor to use DbiFlagSet.

Rename FlagSet to AbstractFlagSet

0f66aaf

Add remaining FlagSet impls

aa000a1

Replace Env#copy(File, CopyFlags...) with copy(File, CopyFlagSet). As there is only one flag this should not be a breaking change. Deprecate Env#txn(Txn, TxnFlags...) as there is now Env#txn(Txn) Env#txn(Txn, TxnFlags) Env#txn(Txn, TxnFlagSet)

Fix Javadoc

667dab3

github-advanced-security bot found potential problems Oct 27, 2025

View reviewed changes

Replace get(Uns|S)ignedComparator with getComparator(DbiFlagSet)

0234d32

Also improve javadoc and refactor some tests to use DbiBuilder. Some tests are failing.

github-advanced-security bot found potential problems Oct 28, 2025

View reviewed changes

src/main/java/org/lmdbjava/BufferProxy.java Fixed Show fixed Hide fixed

Add missing txn commit in DbiBuilder

ef0c852

github-advanced-security bot found potential problems Oct 28, 2025

View reviewed changes

at055612 added 2 commits October 28, 2025 18:21

Change CursorIterableTest to use Parameterized

1b3f94d

Deprecate methods using varargs flags

c0bbe73

at055612 self-assigned this Oct 28, 2025

github-advanced-security bot found potential problems Oct 28, 2025

View reviewed changes

at055612 added 3 commits October 29, 2025 11:32

Add int key compare method to (Direct|Byte)BufferProxy

4fd89ff

Tidy code

58dcc6e

Fix byte order issues with compareAsIntegerKeys

26665ba

benalexau mentioned this pull request Nov 3, 2025

Write regression after release 0.8.3 #268

Closed

at055612 added 2 commits November 4, 2025 15:01

Add/refactor tests

c427801

Merge branch 'master' into mdb_cmp

f606e7e

github-advanced-security bot found potential problems Nov 4, 2025

View reviewed changes

Add integer key comparator tests

e2be6bf

github-advanced-security bot found potential problems Nov 5, 2025

View reviewed changes

at055612 added 2 commits November 5, 2025 16:57

Add ComparatorFactory

1acd971

Merge branch 'master' into mdb_cmp

dea7975

at055612 closed this Nov 5, 2025

gh-249 Remove MDB_UNSIGNEDKEY, let CursorIterable call mdb_cmp #250

gh-249 Remove MDB_UNSIGNEDKEY, let CursorIterable call mdb_cmp #250

Uh oh!

Conversation

at055612 commented Mar 6, 2025

Uh oh!

codecov bot commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check notice

Uh oh!

Uh oh!

Check notice

Uh oh!

Check notice

Uh oh!

Uh oh!

Check notice

Check notice

Uh oh!

Check notice

Uh oh!

Check notice

Check notice

Check notice

Check notice

Uh oh!

at055612 commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Mar 6, 2025 •

edited

Loading