Add Cursor.get(BufferProxy, BufferProxy, SeekOp) method #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for this PR. Would you mind please providing a corresponding test case? |
Contributor
Author
|
What is the highest version of Java that the tests can target? |
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
============================================
+ Coverage 90.98% 91.04% +0.05%
+ Complexity 373 352 -21
============================================
Files 29 28 -1
Lines 1265 1172 -93
Branches 113 106 -7
============================================
- Hits 1151 1067 -84
+ Misses 48 45 -3
+ Partials 66 60 -6
Continue to review full report at Codecov.
|
benalexau
force-pushed
the
master
branch
11 times, most recently
from
8809f8e to
fed0c5d
Compare
benalexau
added a commit
that referenced
this pull request
Apr 15, 2020
benalexau
changed the title
Member
|
Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
necessary for code like
mdb_cursor_get(m_cur_block_heights, (MDB_val *)&zerokval, &val_h, MDB_GET_BOTH)