ByteArrayProxy should be used via its static final field

benalexau · benalexau · commit 57b1b5b48e15 · 2020-05-20T09:13:07.000+10:00
diff --git a/src/main/java/org/lmdbjava/ByteArrayProxy.java b/src/main/java/org/lmdbjava/ByteArrayProxy.java
@@ -40,6 +40,9 @@ public final class ByteArrayProxy extends BufferProxy<byte[]> {
 
   private static final MemoryManager MEM_MGR = RUNTIME.getMemoryManager();
 
+  private ByteArrayProxy() {
+  }
+
   /**
    * Lexicographically compare two byte arrays.
    *
diff --git a/src/test/java/org/lmdbjava/DbiTest.java b/src/test/java/org/lmdbjava/DbiTest.java
@@ -60,6 +60,7 @@
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.TemporaryFolder;
+import static org.lmdbjava.ByteArrayProxy.PROXY_BA;
 import static org.lmdbjava.ByteBufferProxy.PROXY_OPTIMAL;
 import org.lmdbjava.CursorIterable.KeyVal;
 import org.lmdbjava.Dbi.DbFullException;
@@ -327,7 +328,7 @@ public void putCommitGet() {
   @Test
   public void putCommitGetByteArray() throws IOException {
     final File path = tmp.newFile();
-    try (Env<byte[]> envBa = create(new ByteArrayProxy())
+    try (Env<byte[]> envBa = create(PROXY_BA)
         .setMapSize(MEBIBYTES.toBytes(64))
         .setMaxReaders(1)
         .setMaxDbs(2)

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,9 @@ public final class ByteArrayProxy extends BufferProxy<byte[]> {`
`40`	`40`
`41`	`41`	`private static final MemoryManager MEM_MGR = RUNTIME.getMemoryManager();`
`42`	`42`
	`43`	`+ private ByteArrayProxy() {`
	`44`	`+ }`
	`45`	`+`
`43`	`46`	`/**`
`44`	`47`	`* Lexicographically compare two byte arrays.`
`45`	`48`	`*`