Skip to content

[CI][Darwin] Set LLVM_VERSION_SUFFIX to empty#831

Merged
cachemeifyoucan merged 1 commit intollvm:mainfrom
cachemeifyoucan:eng/pr-empty-version-suffix
Apr 6, 2026
Merged

[CI][Darwin] Set LLVM_VERSION_SUFFIX to empty#831
cachemeifyoucan merged 1 commit intollvm:mainfrom
cachemeifyoucan:eng/pr-empty-version-suffix

Conversation

@cachemeifyoucan
Copy link
Copy Markdown
Contributor

When configuring the build, darwin jenkins build runs cmake with '-DLLVM_VERSION_SUFFIX=""', this can cause the version of build to become MAJOR.MINOR.PATCH"". Set LLVM_VERSION_SUFFIX to be empty instead to avoid the "" suffix.

When configuring the build, darwin jenkins build runs cmake with
`'-DLLVM_VERSION_SUFFIX=""'`, this can cause the version of build to
become `MAJOR.MINOR.PATCH""`. Set LLVM_VERSION_SUFFIX to be empty
instead to avoid the `""` suffix.
Copy link
Copy Markdown
Member

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cachemeifyoucan cachemeifyoucan merged commit 45dbab2 into llvm:main Apr 6, 2026
4 checks passed
@cachemeifyoucan cachemeifyoucan deleted the eng/pr-empty-version-suffix branch April 6, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants